Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source map by uploading entire dist folder with map files and lib folder with source #218

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Conversation

cmdcolin
Copy link
Contributor

@cmdcolin cmdcolin commented Sep 14, 2022

This PR may help with complaints from build systems like webpack 5 and perhaps improve some source maps


WARNING in ../../node_modules/binary-parser/dist/esm/binary_parser.mjs
Module Warning (from ../../node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/cdiesh/src/jbrowse-components/node_modules/binary-parser/dist/esm/binary_parser.js.map' file: Error: ENOENT: no such file or directory, open '/home/cdiesh/src/jbrowse-components/node_modules/binary-parser/dist/esm/binary_parser.js.map'

The entire lib and dist folder are used. The dist folder map files are currently not deployed but are referred to by the js files in dist, and the map files, if deployed, would refer to the lib folder. I've made some similar PRs like https://github.com/satya164/react-simple-code-editor/pull/93/files

@keichi keichi merged commit 07c2161 into keichi:master Sep 20, 2022
@keichi
Copy link
Owner

keichi commented Sep 20, 2022

I've just released a new version including the lib/ directory. Could you try if this problem has been resolved?

@cmdcolin
Copy link
Contributor Author

no webpack warning now! thanks :)

@cmdcolin cmdcolin deleted the fix_source_map branch September 20, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants