Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More improvement of kedro micropkg #2893

Closed
noklam opened this issue Aug 3, 2023 · 4 comments
Closed

More improvement of kedro micropkg #2893

noklam opened this issue Aug 3, 2023 · 4 comments

Comments

@noklam
Copy link
Contributor

noklam commented Aug 3, 2023

Description

Find many things while reviewing #2856 (review)
I am trying new format to explain things. https://asciinema.org/a/600655

Context

What's the expect workflow with micropkg? Things has changed and micropkg has not caught up. I notice a few things due to new features

Steps to Reproduce

I expect this should work but it doesn't

  • kedro micropkg package pipelines.nok
  • `kedro micropkg pull <packaged.tar.gz> # from existing workflows
  • kedro run --pipeline <package> or python -m package`

Expected Result

Actual Result

-- If you received an error, place it here.
-- Separate them if you have more than one.

Your Environment

  • Kedro version used (pip show kedro or kedro -V):
  • Python version used (python -V):
  • Operating system and version:
@merelcht
Copy link
Member

I'm actually thinking we should just remove the micropkg feature all together. When things were broken nobody reported it and we don't get a lot of questions about micropackaging. It seems that most users don't even know this exists..

@noklam
Copy link
Contributor Author

noklam commented Mar 27, 2024

@merelcht I have been asking about this so I am all for it😄

@astrojuanlu
Copy link
Member

I'm actually thinking we should just remove the micropkg feature all together.

💯 #3750

@astrojuanlu
Copy link
Member

We decided in #3750 to deprecate kedro micropkg so we will not do this.

@astrojuanlu astrojuanlu closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants