We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a follow up action, we agreed to introduce type like Patterns = Dict[str, Dict[str, Any]] to improve the readability of the code a lot.
Patterns = Dict[str, Dict[str, Any]]
An example can be found here
We can also do this beyond just Patterns but to more complicated types within the code base.
Patterns
As discussed, let's separate the Type Alias proposed in #2770. I will close #2770 and approve this PR now. :) Originally posted by @noklam in #2635 (comment)
As discussed, let's separate the Type Alias proposed in #2770. I will close #2770 and approve this PR now. :)
Originally posted by @noklam in #2635 (comment)
The text was updated successfully, but these errors were encountered:
This could be nicely rewritten to: matches = (parse(pattern, data_set_name) for pattern in data_set_patterns.keys()) return next(filter(None, matches), None)
This could be nicely rewritten to:
matches = (parse(pattern, data_set_name) for pattern in data_set_patterns.keys()) return next(filter(None, matches), None)
Originally posted by @idanov in #2635 (comment)
There are some minor refactoring work linked here, we can address this with this change.
Sorry, something went wrong.
Closed with #2779
No branches or pull requests
Background
As a follow up action, we agreed to introduce type like
Patterns = Dict[str, Dict[str, Any]]
to improve the readability of the code a lot.An example can be found here
We can also do this beyond just
Patterns
but to more complicated types within the code base.The text was updated successfully, but these errors were encountered: