You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note. In theory an implementation of this is non-breaking, so could be done at any time. But I think it will be confusing if done before #2426, which is 0.19.0.
Following #2426, a user needs to manually set KEDRO_LOGGING_CONFIG in order for conf/logging.yml to be used. We should consider whether kedro should have a system to automatically set this environment variable. Such a system would be:
project template includes a new .env file that defines KEDRO_LOGGING_CONFIG=conf/logging.yml
kedro uses something like dotenv to load this file automatically at the beginning of the kedro process
load_dotenv() would go at top of framework/project/__init__.py (must be beforeLOGGING is defined)
This ticket is not to implement the above but to consider whether we actually want to make this change.
Pros:
conf/logging.yml will be used automatically, no need to set the environment variable yourself (assuming we want to leave file-based logging as opt-out rather than opt-in). Hence there's not an unused file sitting in the template
file-based logging therefore enabled by default as it is now
Following #2426, a user needs to manually set
KEDRO_LOGGING_CONFIG
in order forconf/logging.yml
to be used. We should consider whether kedro should have a system to automatically set this environment variable. Such a system would be:.env
file that definesKEDRO_LOGGING_CONFIG=conf/logging.yml
load_dotenv()
would go at top offramework/project/__init__.py
(must be beforeLOGGING
is defined)This ticket is not to implement the above but to consider whether we actually want to make this change.
Pros:
INFO
log messages from your project still get shown without needing to handle the complication Consider removing support for project-side logging.yml #2281 on the framework sideCons:
Pro or con depending on your opinion:
Overall my opinion would be that we should make this change, mainly for the reason of still seeing
INFO
log messages from your project.The text was updated successfully, but these errors were encountered: