Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix messaging level when package compatibility is not satisfied #1877

Closed
1 task done
ravi-kumar-pilla opened this issue Apr 25, 2024 · 1 comment · Fixed by #1904
Closed
1 task done

Fix messaging level when package compatibility is not satisfied #1877

ravi-kumar-pilla opened this issue Apr 25, 2024 · 1 comment · Fixed by #1904
Assignees

Comments

@ravi-kumar-pilla
Copy link
Contributor

ravi-kumar-pilla commented Apr 25, 2024

Description

We check for 2 package compatibilities when running kedro viz run and if the satisified versions are not available we display an error message on the console (based on users debug level). We should make the error message as a warning instead and display more useful message

Context

Image

Steps to Reproduce

  • Try executing kedro viz run on a python environment which does not have kedro-datasets

Expected Result

  • As these packages do not stop kedro viz from loading but hinder only the shareableviz feature, we should let the users know of this

Actual Result

  • It shows an error log but does not affect kedro viz run

Your Environment

Include as many relevant details as possible about the environment you experienced the bug in:

  • Web browser system and version: Chrome
  • Operating system and version: mac
  • NodeJS version used (if relevant):
  • Kedro version used (if relevant):
  • Python version used (if relevant):

Checklist

  • Include labels so that we can categorise your issue
@ravi-kumar-pilla
Copy link
Contributor Author

Hi @rashidakanchwala , While I started working on this, I feel we should re-visit the package compatibilities approach. At this moment, we also support CustomDataset preview and it does not seem correct to have kedro-datasets as a required package. And also, we need to see if fsspec is a mandatory requirement (apart from sqlite store, it is mostly used conditionally and in deployers). For this ticket, I will adjust the message level and change the text. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant