Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for Azure Event Hubs using Workload Identity and Pod Identity #3888

Closed
Tracked by #2357 ...
JorTurFer opened this issue Nov 22, 2022 · 11 comments · Fixed by #4200
Closed
Tracked by #2357 ...

Add e2e test for Azure Event Hubs using Workload Identity and Pod Identity #3888

JorTurFer opened this issue Nov 22, 2022 · 11 comments · Fixed by #4200
Assignees
Labels
help wanted Looking for support from community stale-bot-ignore All issues that should not be automatically closed by our stale bot testing

Comments

@JorTurFer
Copy link
Member

Proposal

We need to add e2e test coverage for the scenario

Use-Case

No response

Anything else?

No response

@JorTurFer JorTurFer added help wanted Looking for support from community testing stale-bot-ignore All issues that should not be automatically closed by our stale bot labels Nov 22, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Nov 22, 2022
@christle
Copy link
Contributor

christle commented Dec 9, 2022

I can do it

@JorTurFer
Copy link
Member Author

Awesome!
You could need to open a PR in testing-infrastructure with the role assignment for granting access to managed identity in eh and storage

@JorTurFer
Copy link
Member Author

JorTurFer commented Dec 9, 2022

This is the repo. It's done with terraform and I guess that the change is small, you need to pass the manage identity or the map of managed identities to event-hub module and storage account module, and the assign the roles. Currently, Service Bus module already has assigned roles, so you could check how it's done here

You can see the terraform plan output in the CI check summary
image

and once it's merged, the infra will be automatically updated

@JorTurFer
Copy link
Member Author

I have already created the role assignments, so you don't need to do anything in testing-infrastructure repo, all the changes you need to do are in this repo 😄

@christle
Copy link
Contributor

Great, Thank you :)

@JorTurFer JorTurFer changed the title Add e2e test for Azure Event Hubs using Workload Identity Add e2e test for Azure Event Hubs using Workload Identity and Pod Identity Jan 23, 2023
@christle
Copy link
Contributor

christle commented Jan 24, 2023

I will start with it in the next few days. I didn't have time over the turn of the year.

@JorTurFer
Copy link
Member Author

No rush, when you have time :)

@JorTurFer
Copy link
Member Author

Hey @christle ,
Do you have any update about this? I'm adding missing azure e2e test and could add this as part of my PR

@JorTurFer
Copy link
Member Author

Hey @christle
I have done it as part of my PR for adding the e2e tests on all azure scalers with pod identities. I hope you haven't started it yet :(

@christle
Copy link
Contributor

christle commented Feb 8, 2023

No Problem. It is totally fine for me. I just did some initial setup task regards infrastructure etc last week. sry for that

@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 8, 2023

f**k, sorry :(
I wanted to close all the e2e issues at once to have full covered azure scalers with pod identities 😞

@github-project-automation github-project-automation bot moved this from Proposed to Ready To Ship in Roadmap - KEDA Core Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Looking for support from community stale-bot-ignore All issues that should not be automatically closed by our stale bot testing
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants