Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the config map routing loop in the Scaler #346

Closed
arschles opened this issue Dec 14, 2021 · 2 comments
Closed

Refactor the config map routing loop in the Scaler #346

arschles opened this issue Dec 14, 2021 · 2 comments
Labels
enhancement New feature or request stale All issues that are marked as stale due to inactivity

Comments

@arschles
Copy link
Collaborator

Currently, when the config map routing loop experiences an update, we do a full update from the k8s API using the scaler's queue pinger.

It may be more efficient to just update the pinger's in-memory copy the host list to reflect the change in the routing table (the pinger would still be pinging all interceptors in a separate goroutine), rather than making a new request to all interceptors every time a change to the set of HTTPScaledObjects is made.

This is a follow-up from #326

Use-Case

A reduction (however small) to the number of network requests made from scaler to interceptors.

Specification

When an event occurs on the HTTPScaledObject set, we should avoid issuing "fan-out" requests (i.e. scaler issues a metrics request to each interceptor and aggregates results) as a result.

@arschles arschles added the enhancement New feature or request label Dec 14, 2021
@stale
Copy link

stale bot commented Feb 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Feb 12, 2022
@arschles
Copy link
Collaborator Author

This has been completed in #326 by @tpiperatgod. closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale All issues that are marked as stale due to inactivity
Projects
None yet
Development

No branches or pull requests

1 participant