Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template separator appears in jj operation log output for commands that came from jjk #3

Closed
keanemind opened this issue Feb 11, 2025 · 2 comments

Comments

@keanemind
Copy link
Owner

keanemind commented Feb 11, 2025

After using the extension for a while, the operation log view refuses to update and emits an Missing fields in the output. error repeatedly in the Extension Host output because when jjk runs a command with a template, the template's separator appears in the resulting operation's tags. This confuses the extension's parser for jj operation log which breaks the operation log view. See this output from jj operation log for an example:

293b5ceaad6c [email protected] 7 minutes ago, lasted 56 milliseconds
snapshot working copy
args: jj show --no-pager -T 'change_id ++ "ඞjjk
" ++ commit_id ++ "ඞjjk
" ++ author.name() ++ "ඞjjk
" ++ author.email() ++ "ඞjjk
" ++ author.timestamp().local().format("%F %H:%M:%S") ++ "ඞjjk
" ++ description ++ "ඞjjk
" ++ empty ++ "ඞjjk
" ++ conflict ++ "ඞjjk
" ++ diff.summary() ++ "ඞjjk
"' owknuzkl

@HKalbasi thank you for bringing this to my attention via jj-vcs/jj#3219 (comment). This is a bug in jjk that I think we can address by having our jj operation log template use a different separator than the templates of all our other commands. jjk's calls to jj operation log shouldn't themselves end up in the operation log because we use --ignore-working-copy.

@keanemind
Copy link
Owner Author

This should be fixed by c5d0846 which will be included in the next release.

@HKalbasi
Copy link

jjk's calls to jj operation log shouldn't themselves end up in the operation log because we use --ignore-working-copy.

That's a nice trick. Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants