-
Notifications
You must be signed in to change notification settings - Fork 98
PHAsset GIF support #41
Comments
GIFs (as well as webp) are supported just for remote resources. |
DFImageFetching should probably return NSData instead of UIImage (DFImageDataFetching). It was returning UIImage because of the AssetsLibrary that doesn't provide access to NSData of thumbnail and fullScreenImage. It might be worth to either simply drop AssetsLibrary support or reimplementing it to work with fullsize image data. |
DFPhotosKitImageFetcher:
DFURLImageFetcher:
DFAFImageFetcher:
|
Overall, these changes lead to much cleaner implementation. And it enables much cleaner progressive JPEG implementation. |
Done in develop branch |
More of a question than a bug, but are GIFs supported for PHAssets or just remote resources loaded via url? I ended up inspecting the UTI in the info dictionary and then loading the GIF as data with the standard -[PHImageManager requestImageDataForAsset:options:resultHandler:]. Thanks and nice framework ... can't believe I hadn't seen it till now.
The text was updated successfully, but these errors were encountered: