-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] add vitest #130
[feature] add vitest #130
Conversation
@blcham |
xit --> test.skip |
5683860
to
47e7e0b
Compare
@shellyear still there are 57 files committed (i.e. to review), you need to rebase from main: |
@blcham I did it manually using, git fetch upstream & git pull upstream main. But most likely will use sync fork next time |
47e7e0b
to
ce1f029
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nicely done!, can be merged after resolved comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that tests are again failing.
2b93f6b
to
2613398
Compare
…om vitest, vi.fn instead of jest.fn;
… mimic the callback style
…ime with vitest default testTimout
2613398
to
03235d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job!
Partially resolves #110
@blcham
There are remaining errors that are not shown in the terminal, but in the build pipeline:
[1]
[2]
[3] warning
stderr | tests/tests/components/User.spec.jsx > User > renders filled admin's form
Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17. Learn more: https://reactjs.org/link/switch-to-createroot
UPD: all errors are runtime and relate to UserActions.spec.jsx
e.g