Fix/23 ava distributioni 148 require accsess permision from kc remote user #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blcham
requested changes
Nov 1, 2024
|
@kostobog I guess we cannot merge this PR as 23ava-distribution will stop working, right? If so I would just rebase and NOT MERGE!!! yet |
|
@kostobog see my comment in PR |
- role name n lowercase - remove explicit prefix - replace role literals with constant where possible
…curity provider literals with constants
…is oidc don't add a default user role
…rity provider In SecurityConfig: - fix configurable role prefix not set using GrantedAuthorityDefaults - fix http authorization rules are defined with roles without prefix In MainUserDetailsService - Add default user role to authenticated user if security provider is "internal"
kostobog
force-pushed
the
fix/23-ava-distributioni-148-require-accsess-permision-from-kc-remote-user
branch
from
840a69b to
f0c3278
Compare
|
@blcham |
|
@blcham |
|
@kostobog please rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@blcham
Fix partially kbss-cvut/23ava-distribution#148
Refactoring roles:
-instead of_separatorff-Method authorization rules (annotations) are using the
hasRoleexpression in while the record manager is usinghasAuthorityexpression. The difference is that thehasRoleexpression has a default role prefix which can be configured (ROLE_is used when default role prefix is not configured) whilehasAuthoritydoes not have a prefix. For example:hasRole("user")in this PR will check for authorityff-userhasAuthority("user")in this PR will check for authorityuser