jupyter and ipython code-blocks #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for >>> blocks outside of code-blocks Add ipython as identifier for python blocks Signed-off-by: Fabian Haase <[email protected]>
kataev
reviewed
Oct 26, 2018
flake8_rst/rst.py
Outdated
|
|
||
| def find_sourcecode(src): | ||
| for match in RST_RE.finditer(src): | ||
| origin_code = match.group('code') | ||
| for expression in [RST_RE, ANCHOR_RE]: |
There was a problem hiding this comment.
Maybe just create many matches, without extend indent?
for example:
matches = (match for expression in EXPRESSIONS for match in expression.finditer(src)]
for match in matches:
# old codeThere was a problem hiding this comment.
Great idea, much cleaner.
kataev
reviewed
Oct 26, 2018
tests/data/example_10.py
Outdated
|
|
||
| >>> print('This line is highlighted.') | ||
| This line is highlighted. | ||
| """ |
There was a problem hiding this comment.
Add newline at end of file plz.
kataev
reviewed
Oct 26, 2018
| @@ -3,13 +3,14 @@ | |||
|
|
|||
| RST_RE = re.compile( | |||
| r'(?P<before>' | |||
| r'^(?P<indent> *)\.\. (code-block|sourcecode):: (python|pycon)\n' | |||
| r'^(?P<indent> *)\.\. (code-block|sourcecode|ipython):: (python|pycon)\n' | |||
There was a problem hiding this comment.
If i read properly, ipython directive use without (python|pycon)
And ipython console output contain square brackets, without >>>, how does it work?
There was a problem hiding this comment.
maybe I've been a little bit too enthusiastic, however in pandas they use directives like
.. ipython:: python followed by plain python code. [with some roles like :suppress: sometimes]
These cases would be covered as well.
Signed-off-by: Fabian Haase <[email protected]>
FHaase
force-pushed
the
feature/jupyter
branch
from
a73b619 to
7ca2de2
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for >>> blocks outside of code-blocks
Add ipython as identifier for python blocks