0015: Refactor Tests to Not Return Result<_> for Clearer Errors #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's kinda' sorta' explained here: <rust-lang/rust#69517>. Basically, though, tests that return a `Result<_>` will have less helpful backtraces than tests that just use asserts and `unwrap()/expect(_)` all over the place. I recently ran into an undiagnosable test failure that this commit makes diagnosable, so this is now "the way things are done" for this project, going forwards.
karlmdavis
force-pushed
the
0015-tests-return-void
branch
from
d8619e3 to
4f84938
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's kinda' sorta' explained here: rust-lang/rust#69517. Basically, though, tests that return a
Result<_>will have less helpful backtraces than tests that just use asserts andunwrap()/expect(_)all over the place.I recently ran into an undiagnosable test failure that this commit makes diagnosable, so this is now "the way things are done" for this project, going forwards.
(see title)
This is part of the work on User Story 15: Switch to Tracing for Logs.