Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null at the begining of each yaml file rendered via helm binding integration #735

Closed
ofen opened this issue May 21, 2021 · 1 comment
Closed

Comments

@ofen
Copy link

ofen commented May 21, 2021

Describe the bug/feature
Yaml files rendered via helm binding integration contains null at the beginning of each rendered file e.g.

null
---
apiVersion: batch/v1beta1
kind: CronJob
metadata:
  labels:
    app.kubernetes.io/instance: foobar
    app.kubernetes.io/managed-by: Tiller
    app.kubernetes.io/name: foobar
    helm.sh/chart: foobar-v1
  name: foobar
  namespace: default
spec:
  jobTemplate:
    spec:
       ...

To Reproduce

  1. Install kapitan and helm binding from master
git clone https://github.com/kapicorp/kapitan.git && \
  cd kapitan/ && \
  git submodule init  && \
  git submodule update && \
  make build_helm_binding && \
  pip3 install .
  1. Create dummy chart via helm create foobar in .charts/ directory
  2. Create class
---
parameters:
  kapitan:
    compile:
    - output_path: charts/
      input_type: helm
      input_paths:
      - .charts/foobar
      helm_values:
        foo: bar
      helm_params:
        namespace: default
        release_name: foobar
  1. Add class to target
  2. Compile kapitan compile
  3. Open ./compiled/${target}/charts/foobar/templates
  4. Open any yaml file

Expected behavior
No null values at the beginning of rendered files

@ofen
Copy link
Author

ofen commented Aug 12, 2021

Looks like fixed by #701

@ofen ofen closed this as completed Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant