Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip interval start could be after end #1065

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

akloeckner
Copy link
Collaborator

  • basically: use milliseconds in constants rather than fractions of hours
  • also remove strange intervall size of n_points if hours < 1 and points/hour < 1
  • also use 1 minute offset for end only when group_by, because that is cosmetics actually

fixes #181

* basically: use milliseconds in constants rather than fractions of hours
* also remove strange intervall size of n_points if hours < 1 and points/hour < 1
* also use 1 minute offset for end only when group_by, because that is cosmetics actually

fixes kalkih#181
@akloeckner
Copy link
Collaborator Author

akloeckner commented Jan 28, 2024

@ildar170975 , could you please check, if this solves your issue? According to our contributing guidelines, I'd like to have your approval also for the cleanup part. So, please also check, if your other graphs (especially using group_by) are still fine.

The js bundle should be available as described in #1064 .

@ildar170975
Copy link
Collaborator

@akloeckner
Is it this one?

image

@ildar170975
Copy link
Collaborator

@akloeckner
Tested with that js.
Code from here.
Seems that the issue is fixed.

@ildar170975
Copy link
Collaborator

ildar170975 commented Jan 28, 2024

But I see this glitch now - no date is shown:

image

Today 28.01.24 17:44, selected a point from yesterday.

Update: no, this is an old behaviour... should be fixed too. Will prepare an issue. - DONE

@akloeckner
Copy link
Collaborator Author

Yes, that's the download I meant. 👍

Good to see, the original glitch seems fixed. I still don't fully understand why. I think it's something about multiplying small numbers (1/120h interval between points) with big ones (3600000ms in an hour). 🤷

Let me know, when (and if) you're confident, this could be merged!

@ildar170975
Copy link
Collaborator

ildar170975 commented Jan 28, 2024

when (and if) you're confident, this could be merged!

Let's merge it... The more people will test it - the better.
In my old practice (cruise missiles from 1997) even a probably tiny fix needs a full-scope testing, testers should consider a product as a "black box". But this is not a "rocket science" ))

@akloeckner
Copy link
Collaborator Author

:-) Agreed!

@akloeckner akloeckner merged commit 930ee39 into kalkih:dev Jan 28, 2024
4 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 20, 2024
## [0.12.1](v0.12.0...v0.12.1) (2024-03-20)

### Bug Fixes

* tooltip interval start could be after end ([#1065](#1065)) ([930ee39](930ee39)), closes [#181](#181)
Copy link

🎉 This PR is included in version 0.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to motorlatitude/mini-graph-card that referenced this pull request Dec 15, 2024
# 1.0.0 (2024-12-15)

### Bug Fixes

* add first datapoint tooltip for line graph ([kalkih#882](https://github.com/motorlatitude/mini-graph-card/issues/882)) ([7576fe6](7576fe6))
* allow zero tooltip ([057a395](057a395)), closes [kalkih#805](https://github.com/motorlatitude/mini-graph-card/issues/805)
* cards would always assume icon_image was set ([kalkih#957](https://github.com/motorlatitude/mini-graph-card/issues/957)) ([f376732](f376732))
* display a warning if entity is not available ([kalkih#545](https://github.com/motorlatitude/mini-graph-card/issues/545)) ([a334b84](a334b84)), closes [kalkih#487](https://github.com/motorlatitude/mini-graph-card/issues/487)
* drop out-of-bound coords in reducer ([kalkih#881](https://github.com/motorlatitude/mini-graph-card/issues/881)) ([527f005](527f005)), closes [kalkih#251](https://github.com/motorlatitude/mini-graph-card/issues/251)
* Fix undefined variable introduced by [kalkih#545](https://github.com/motorlatitude/mini-graph-card/issues/545) ([9e923f5](9e923f5))
* icon will properly follow entity's device_class [[kalkih#484](https://github.com/motorlatitude/mini-graph-card/issues/484)] ([2f9e0a7](2f9e0a7))
* retain the last out-of-bounds state ([kalkih#961](https://github.com/motorlatitude/mini-graph-card/issues/961)) ([8ebe173](8ebe173)), closes [kalkih#881](https://github.com/motorlatitude/mini-graph-card/issues/881) [kalkih#960](https://github.com/motorlatitude/mini-graph-card/issues/960)
* Support for `fire-dom-event` ([c29f55f](c29f55f)), closes [kalkih#563](https://github.com/motorlatitude/mini-graph-card/issues/563)
* tooltip interval start could be after end ([kalkih#1065](https://github.com/motorlatitude/mini-graph-card/issues/1065)) ([930ee39](930ee39)), closes [kalkih#181](https://github.com/motorlatitude/mini-graph-card/issues/181)
* **config:** Remove entity config error [kalkih#592](https://github.com/motorlatitude/mini-graph-card/issues/592) ([kalkih#593](https://github.com/motorlatitude/mini-graph-card/issues/593)) ([53d923a](53d923a))
* **documentation:** enquote html color ([dbdeab8](dbdeab8)), closes [kalkih#872](https://github.com/motorlatitude/mini-graph-card/issues/872)
* **log:** color_thresholds render incorectly with logaritmic on ([kalkih#542](https://github.com/motorlatitude/mini-graph-card/issues/542)) ([b704885](b704885)), closes [kalkih#531](https://github.com/motorlatitude/mini-graph-card/issues/531)
* **stalebot:** issues should also use exemptLabels ([4d74c1f](4d74c1f))
* **workflows:** remove invalid description field ([e755e24](e755e24))
* Time would sometime display 24:xx instead of 00:xx [[kalkih#536](https://github.com/motorlatitude/mini-graph-card/issues/536)] ([7c7d921](7c7d921))

### Features

* Add support of attribute tree when available ([kalkih#996](https://github.com/motorlatitude/mini-graph-card/issues/996)) ([9c1c31e](9c1c31e))
* Interpolate color threshold stops ([kalkih#596](https://github.com/motorlatitude/mini-graph-card/issues/596)) ([3826c0d](3826c0d))
* pull two years worth of changes into release channel ([f5fb98d](f5fb98d)), closes [kalkih#1059](https://github.com/motorlatitude/mini-graph-card/issues/1059)
* **attribute:** Retrieve an attribute instead of the state ([kalkih#564](https://github.com/motorlatitude/mini-graph-card/issues/564)) ([708bfde](708bfde)), closes [kalkih#411](https://github.com/motorlatitude/mini-graph-card/issues/411) [kalkih#245](https://github.com/motorlatitude/mini-graph-card/issues/245) [kalkih#501](https://github.com/motorlatitude/mini-graph-card/issues/501)
* **graph:** Add median aggregate function ([kalkih#521](https://github.com/motorlatitude/mini-graph-card/issues/521)) ([57219bd](57219bd))
* **option:** override icon with an image URL ([kalkih#789](https://github.com/motorlatitude/mini-graph-card/issues/789)) ([2860a09](2860a09))
* Format numbers according to selected language [[kalkih#495](https://github.com/motorlatitude/mini-graph-card/issues/495) [kalkih#509](https://github.com/motorlatitude/mini-graph-card/issues/509)] ([5785bd8](5785bd8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants