-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import statement is not inserted when only a enum is used. #780
Comments
I'm not sure, but this might be the same problem as #651. |
That one errors in transpile time. This one errors in run time (at least for python). |
Actually, it's a duplicate of #703 (comment). It seems that it doesn't matter if you reference a nested user-type or a nested enum type from the imported spec. I'll try to solve it in the near future.
Thanks for pointing out issue #651, I didn't know about it (most likely because I often filter the issues by label "bug found", but that issue didn't have it until now). Yeah, it seems like the same problem as well.
Apparently not anymore, you can see on the timeline of issue #651 that commit kaitai-io/kaitai_struct_compiler@5d4881a solved the problem with the compiler failing to generate the parser. Now it really fails only at run time, as you can see in the CI dashboard (search for test |
Duplicate of #651 |
To reproduce compile bluetooth_hcd from kaitai-io/kaitai_struct_formats#305 and see that https://github.com/kaitai-io/kaitai_struct_formats/pull/305/files#diff-d5dc77b92e2d98a1f9ab5b90cbdb3fe4R21 doesn't cause
BluetoothVendorsIds
be imported.The text was updated successfully, but these errors were encountered: