enum directive ignored in params list

[webbnh]

type:
  # ...
  payload:
    params:
    - id: rec_type
      enum: rec_types
      type: u1
    seq:
    - id: data
      #process: xor(0)
      type:
        cases:
          rec_types::type_1: type_1
          rec_types::type_2: type_2
        switch-on: rec_type

Produces errors, such as:

/types/payload/seq/0/type/cases/EnumByLabel(identifier(rec_types),identifier(type_2)): can't compare Int1Type(false) and EnumType(List(rec_types),CalcIntType)

(See Lobby discussion.)

[GreyCat]

Ok, just for clarity, this seems to be caused not by type switching, so basically anything like that should reproduce the bug:

meta:
  id: params_enum
enums:
  animals:
    1: cat
    2: dog
seq:
  - id: one
    type: u1
    enum: animal
  - id: invoke_with_param
    type: with_param(one)
types:
  with_param:
    params:
      - id: enumerated_one
        type: u1
        enum: animal
    instances:
      is_cat:
        value: enumerated_one == animals::cat # would break if there's a bug

[zolo]

I'd like to see enum param support as well. A workaround is to pass ints and cast the cases using to_i

[GreyCat]

Actually, I've just checked, support for enums in params was implemented ages ago: kaitai-io/kaitai_struct_compiler@41e9a06

I've just added test to confirm that — see ParamsEnum: http://kaitai.io/ci/

[KOLANICH]

Have just checked on the latest ver from appveyor, doesn't work on this file: https://github.com/KOLANICH/kaitai_struct_formats/blob/mdt/scientific/nt_mdt/nt_mdt.ksy#L89

[GreyCat]

Thanks, caught yet another problem ;) New version should be available in ~15 minutes, please try again?

[KOLANICH]

Still fails. Could you test on the spec I have referenced?

[GreyCat]

That exact spec you're referring to is obviously broken, at least in respect supplying "type" as enum, and then switching over it as it was an integer. Here's a slightly fixed version that I was testing upon: https://gist.github.com/GreyCat/e99663ca7cbc31300c07ddea9352677d

If you're still getting an error, please state (1) which .ksy file exactly you're using, (2) what error you're getting.

[GreyCat]

No replied for 1 month, from my perspective everything was fixed. Closing for now, please feel free to reopen if you still have repro.

[KOLANICH]

Here's a slightly fixed version that I was testing upon: https://gist.github.com/GreyCat/e99663ca7cbc31300c07ddea9352677d

That works, thank you.

[hakanai]

I see this issue both on https://ide.kaitai.io/ and on https://ide.kaitai.io/devel right now. Same workaround of adding .to_i fixes it for me. It's quite possible that the deployed versions are out of date, but exactly how out of date?

[GreyCat]

@trejkaz Unfortunately:

1. IDE deployment is broken now :( You can see deployed versions in about box.
2. We never had automated deployment of new versions of compiler.
3. Publications of JS versions of compiler to npmjs is broken as well :(

[hakanai]

Hmm, so what's the path right now for getting a working IDE of some sort to work with KTS files? I had planned to some day make my hex viewer able to deal with them but it's probably a lot of work to get that up and going.