Feat/auth 로그인 페이지의 alert를 Mui Alert로 변경과 토큰 검증 및 갱신 자동화 #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yewon830
approved these changes
Jun 28, 2024
Comment on lines
+18
to
+27
| // axios 인터셉터 설정 컴포넌트 | ||
| const InterceptorSetup: React.FC<InterceptorSetupProps> = ({ children }) => { | ||
| const store = useLoginStore(); | ||
| const navigate = useNavigate(); | ||
| React.useEffect(() => { | ||
| interceptorSetup(store, navigate); | ||
| }, [store, navigate]); | ||
|
|
||
| return <>{children}</>; | ||
| }; |
There was a problem hiding this comment.
저는 axios 인스턴스를 새로 만들어서 interceptor로 토큰 검증 로직짜고, 만든 인스턴스를 가져다 쓰는 쪽으로 사용했었는데,
여기다가 함수 호출해서 interceptor 설정하는 방법도 있는지 몰랐어요. 이런 방법도 있었군요 신기하네요
주석도 다 달아 놓으셔서 이해하기 편했습니다!
근데 안쓰는 console.log()가 메모리 누수나 성능에 안좋아서 필요 없는 부분+ 테스트 끝난 부분 있으시면 지우는게 좋대요
There was a problem hiding this comment.
console.log()의 경우 로그인 관련 기능개발이 완전히 다 끝나면 지우도록 하겠습니다 :) 조언 감사합니다!
minisundev
approved these changes
Jun 30, 2024
jihyun-j
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝작업 내용
로그인 성공시
검증 성공시
검증 실패시
스크린샷 (선택)
💬리뷰 요구사항(선택)