[User] 친구목록 조회 API 구현 #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yudonggeun
approved these changes
Jun 26, 2024
| val friend = friendRelation.friend | ||
| val profileImgUrl = friend.file?.let { imagePath.resolve(it) } | ||
| GetFriendResponse(friend.id!!, friend.username, friend.email, profileImgUrl) | ||
| }.collect(Collectors.toList()) |
There was a problem hiding this comment.
collect(Collectors.toList()) -> toList() 메서드를 적용하는 것도 좋아보이네요!
Comment on lines
+17
to
+22
| /** | ||
| * 로그인한 사용자가 친구목록을 조회하는 메서드 | ||
| * | ||
| * @param userId : 로그인한 사용자의 ID. | ||
| * @return 로그인한 사용자 ID, 해당 사용자가 조회하고자 하는 친구목록을 담은 GetFriendsResponse 리턴 | ||
| */ |
There was a problem hiding this comment.
인터페이스를 통해서 노출된 메서드의 주석 좋네요.
Comment on lines
+253
to
+258
| mockk<User> { | ||
| every { id } returns CommonTest.TEST_FRIEND_ID | ||
| every { username } returns CommonTest.TEST_FRIEND_USERNAME | ||
| every { email } returns CommonTest.TEST_FRIEND_EMAIL | ||
| every { file } returns CommonTest.TEST_PROFILE_IMG | ||
| } |
| @@ -244,4 +245,37 @@ internal class FriendServiceImplTest : FunSpec({ | |||
| } | |||
| exception.errorCode.message() shouldBe "해당하는 친구가 없습니다." | |||
| } | |||
|
|
|||
| test("친구조회_성공") { | |||
There was a problem hiding this comment.
given when then으로 상황을 주석으로 분리하면 좀 더 파악하기 쉬울 것 같아요.
minisundev
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용