[Chat] 서버 전체 채팅 조회 API 구현 GET api/v1/chat #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore : dev 브랜치 추가로 인한 pr test 수정
yudonggeun
reviewed
Jun 2, 2024
Comment on lines
41
to
46
| if (type.equals("Room")) { | ||
| result = chatService.getRoomChats(id, userId, page) | ||
| } else if (type.equals("Server")) { | ||
| val serverList = serverClient.getServerList(token, GetServerCondition()).body!!.data!! | ||
| result = chatService.getServerChats(id, userId, page, serverList) | ||
| } |
There was a problem hiding this comment.
여기도 ChatType을 받을까 하다가 requestParam 방식으로 받게 되어서 저렇게 했는데 ChatType.ROOM.toString()이라도 쓰는게 나아보이긴 하네요~! 다시 보니 createServerChat할때 만든 ChatType이 merge되지 않아서 쓸 수 없었어요..!
Comment on lines
39
to
46
| var result: List<ChatResponse>? = null | ||
|
|
||
| if (type.equals("Room")) { | ||
| result = chatService.getRoomChats(id, userId, page) | ||
| } else if (type.equals("Server")) { | ||
| val serverList = serverClient.getServerList(token, GetServerCondition()).body!!.data!! | ||
| result = chatService.getServerChats(id, userId, page, serverList) | ||
| } |
There was a problem hiding this comment.
val result = when(type) {
"Server" -> return chatService.getRoomChats(id, userId, page)
"Room" -> return chatService.getServerList(token, ..)
}when을 이용하면 var을 안써도 괜찮을 것 같아요.
Comment on lines
87
to
100
| fun convertRoomChatsToResponses(roomChats: List<RoomChat>): List<ChatResponse> { | ||
| val chatResponse = | ||
| roomChats.map { chat -> | ||
| ChatResponse(chat.id!!, chat.isEdited(), chat.createdAt.toString(), chat.content) | ||
| } | ||
| return chatResponse | ||
| } | ||
|
|
||
| fun convertServerChatsToResponses(chats: List<ServerChat>): List<ChatResponse> { | ||
| val chatResponse = | ||
| chats.map { chat -> | ||
| ChatResponse(chat.roomId, chat.isEdited(), chat.createdAt, chat.content) | ||
| ChatResponse(chat.id!!, chat.isEdited(), chat.createdAt.toString(), chat.content) | ||
| } | ||
| return chatResponses | ||
| return chatResponse |
There was a problem hiding this comment.
확장된 기능이 아니라면 private하는 것은 어떨까요?
| return | ||
| } | ||
| } | ||
| throw GlobalException(ErrorCode.FORBIDDEN_SERVER) |
There was a problem hiding this comment.
ServiceException을 사용하지 않고 GlobalException을 사용하신 이유가 있을까요?
There was a problem hiding this comment.
에러 핸들러를 추가할 필요가 없다고 생각해서 공용으로 쓰고 있었습니다~
| .header("Authorization", "Bearer mock_token") | ||
| .exchange() | ||
|
|
||
| val docs = result.expectStatus().isOk.expectBody().json(om.writeValueAsString(ApiResponse(data = data))) |
There was a problem hiding this comment.
가독성을 위해서 라인을 구분해주시면 더 좋을 것 같아요.
| // When | ||
| val result = | ||
| webTestClient.get().uri( | ||
| URLBuilder(url).query("id", roomId).query("type", "Room").query("page", 1).build(), |
There was a problem hiding this comment.
가독성을 위해서 라인을 구분해주시면 더 좋을 것 같아요.
|
main말고 dev로 pr 생성해서 머지해주세요 |
네 |
|
pr에서 동적으로 브랜치 바꾸는거 처음 알았어요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#122
📝작업 내용
서버 전체 채팅 조회 기능을 개발했습니다