-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress stopping at 66 frames #1217
Comments
Hmm interesting, seems like some kind of encoding or buffer issue. Have you looked at the debugging logs? Goto debug > set log level to debug > check Show Logs |
Well, that's the problem. If I enable to show logs, instead of just stopping at 66 frames, the program crashes, so I can't save any logs to see what's going on. I'll keep trying anyway, maybe I'm lucky and I can save a log without a crash happening |
That's interesting. I'm about to release a new version today, so you could try that in like a few hours. If you send me the video I can also check if it's the video that's causing the issue. |
The new version is out. You can give that a try too. |
Mine fails at frame 66 as well everytime. Here's my debug log: Edit: I thought it was all files but I had only tried about 10 different wmv files. Tried an mp4 and it didn't fail at 66. Are wmv files not supported? |
It might be because of how the file was encoded. Perhaps it's VBR or something? If you could send me one of the files that failed I can debug it and see what's wrong with the video. In theory if it's a video file it SHOULD be supported. If it's breaking then it's a bug. Maybe it's an edge case or something I didn't consider when writing the current code. This new version is a complete rewrite in C++ so I have to consider a lot of low level stuff. Maybe I missed something. You can either send it here or to my email at [email protected]. You can also use something like Google Drive or wormhole.app. Having a broken video to test with will help speed things up a lot. |
Please also try these, separately:
It might be a non-video stream that's causing the issues. |
NP, it's the least I could do. I just tried with the new version and the same happens. I already had disabled "Copy audio and...", so I just changed the container to mkv. This is Realesrgan log: [2024-11-06 00:29:06.347] [info] Output video dimensions: 2560x1920 Link to my Drive for a video giving the error. I downloaded it from the Internet Archive: Same video, but downloaded from Youtube, therefore reencoded, and working fine in Video2X: |
Thanks. I'll take a look at it shortly. |
Thanks I was able to reproduce the issue. I'll see how this can be fixed. |
I'm in no hurry, since I can do with videos from youtube and all of them work well, but it can be of help for other users |
I fixed it: It was not I/B/P frames. The issue was with stream mapping. I did some bad math that causes the streams to not be mapped correctly when the first stream in the file isn't the video stream. Usually video files have the first stream as the video and the second would be audio, but the problematic file was the other way around. My tests didn't cover this case so I didn't catch this issue before. I'll close this issue when the fix commit is fixed. |
Issue fixed in 33b7c53. It will be rolled out in the next release, probably 6.1.1 |
Fantastic, thank you! |
Video2x 6.0.0 Qt6
Windows 10 64bits
NVidia RTX 3070
AMD FX-8320
I'm having this issue with both RealERSGAN, no matter the model, and libplacebo, with many of the videos I'm trying to upscale. It stops processing at exactly 66 frames, I get the message "Video processing failed for: [filename].mp4". Can't write a log, if I try the program just crashes after stopping at 66 frames without saving any logs
Something I've noticed about the source videos that failed and the ones that succeeded, looking at their properties:
[V: h264 main L3.0, yuv420p, WIDTHxHEIGHT, XXX kb/s] <- These failed
[V: ISO Media file produced by Google Inc. (h264 main L3.0, yuv420p, WIDTHxHEIGHT, XXX kb/s)] <- These succeeded
The latter are downloaded from Youtube, therefore reencoded by Youtube. The former are downloaded from other sources
I find it weird to say the least, I don't know if it's something to be expected, or if it happens to someone else
Thank you in advance and, most of all, thanks for this amazing program
The text was updated successfully, but these errors were encountered: