[Release-1.26] - k3s etcd-snapshot delete fail to delete local file when called with s3 flag

[osodracnai]

Backport fix for k3s etcd-snapshot delete fail to delete local file when called with s3 flag

• k3s etcd-snapshot delete fail to delete local file when called with s3 flag #8137

[ShylajaDevadiga]

Validated on release-1.26 branch using commit id 52e2c08

Environment Details

Infrastructure
Cloud EC2 instance

Node(s) CPU architecture, OS, and Version:

> cat /etc/os-release
NAME="SLES"
VERSION="15-SP4"
VERSION_ID="15.4"
PRETTY_NAME="SUSE Linux Enterprise Server 15 SP4"

Cluster Configuration:
Single node

Config.yaml:

cat /etc/rancher/k3s/config,yaml
write-kubeconfig-mode: "0644"
tls-san:
  - fake.fqdn.value
cluster-init: true

Steps to reproduce

1. Copy config.yaml
2. Install k3s
3. Create a snapshot in s3
4. Delete it using the s3-flags
5. List the snapshots without using the s3-flags

Replication results:

> k3s -v
k3s version v1.26.7+k3s1 (e47cfc09)
go version go1.20.6

sudo k3s etcd-snapshot save \
--s3 \
--s3-bucket=<S3-BUCKET-NAME> \
--s3-access-key=<S3-ACCESS-KEY> \
--s3-secret-key=<S3-SECRET-KEY>

sudo k3s etcd-snapshot ls \
--s3 \
--s3-bucket=<S3-BUCKET-NAME> \
--s3-access-key=<S3-ACCESS-KEY> \
--s3-secret-key=<S3-SECRET-KEY>
...
Name                                  Size    Created
on-demand-ip-172-31-2-84-1691537515   5320736 2023-08-08T23:31:56Z

Delete from s3

sudo k3s etcd-snapshot delete\
--s3 \
--s3-bucket=<S3-BUCKET-NAME> \
--s3-access-key=<S3-ACCESS-KEY> \
--s3-secret-key=<S3-SECRET-KEY> on-demand-ip-172-31-2-84-1691537515

Deleted from s3

sudo k3s etcd-snapshot ls \
--s3 \
--s3-bucket=<S3-BUCKET-NAME> \
--s3-access-key=<S3-ACCESS-KEY> \
--s3-secret-key=<S3-SECRET-KEY>
...
Name Size Created

Snapshot is present locally

sudo k3s etcd-snapshot ls
...
Name                                Location                                                                            Size    Created
on-demand-ip-172-31-2-84-1691537515 file:///var/lib/rancher/k3s/server/db/snapshots/on-demand-ip-172-31-2-84-1691537515 5320736 2023-08-08T23:31:55Z

Validation results:

> k3s -v
k3s version v1.26.7+k3s-52e2c08a (52e2c08a)
go version go1.20.6

sudo k3s etcd-snapshot save \
--s3 \
--s3-bucket=<S3-BUCKET-NAME> \
--s3-access-key=<S3-ACCESS-KEY> \
--s3-secret-key=<S3-SECRET-KEY>

sudo k3s etcd-snapshot ls \
--s3 \
--s3-bucket=<S3-BUCKET-NAME> \
--s3-access-key=<S3-ACCESS-KEY> \
--s3-secret-key=<S3-SECRET-KEY>
...
Name                                  Size    Created
on-demand-ip-172-31-14-143-1691537509 5189664 2023-08-08T23:31:51Z

Delete from s3

sudo k3s etcd-snapshot delete\
--s3 \
--s3-bucket=<S3-BUCKET-NAME> \
--s3-access-key=<S3-ACCESS-KEY> \
--s3-secret-key=<S3-SECRET-KEY>

Deleted from s3

sudo k3s etcd-snapshot ls \
--s3 \
--s3-bucket=<S3-BUCKET-NAME> \
--s3-access-key=<S3-ACCESS-KEY> \
--s3-secret-key=<S3-SECRET-KEY>
...
Name Size Created

Snapshot is also deleted locally

sudo k3s etcd-snapshot ls
...