Skip to content

Certificate expiration events persist after certificates are rotated #12107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brandond opened this issue Apr 11, 2025 · 0 comments
Open

Certificate expiration events persist after certificates are rotated #12107

brandond opened this issue Apr 11, 2025 · 0 comments
Assignees

Comments

@brandond
Copy link
Member

Is your feature request related to a problem? Please describe.
When K3s certificates are about to expire, a Kubernetes Event with a Node certificates require attention message is emitted periodically. When the node is restarted to renew certificates, the event does not go away immediately - it just stops being emitted, and will disappear after an hour. This is generally how Events work (they aren't removed, they just expire) but it is somewhat unintuitive.

Describe the solution you'd like
Would be nice if there was a message indicating that certs are all OK / not expired. Absent any specific message indicating that the certs are OK, it is easy to assume that the certs are still expired.

Describe alternatives you've considered
Just wait for the event to go away an hour after they are rotated.

Additional context
In order to track this across restarts, we'd want to add a label or annotation to the Node when certs are expired, and remove this annotation and emit the OK event when no certs are expired.

Label might be nice, because then we could use other tools to label-select nodes with expired certs.

@brandond brandond self-assigned this Apr 11, 2025
@brandond brandond moved this from New to Next Up in K3s Development Apr 11, 2025
@brandond brandond added this to the 2025-05 Release Cycle milestone Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Next Up
Development

No branches or pull requests

1 participant