Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: use "hire them" instead of "tame it" wording, since they are human #40

Open
son0fether opened this issue Apr 11, 2023 · 0 comments

Comments

@son0fether
Copy link

I'd like to request a string change. I know that internally, the human companions are tamed mobs. However, the "tame" terminology is used at one point in the GUI for the mod. It feels pretty weird to see "... It can be tamed again." in the tooltip for the "Release" button. Could that be "... They can be hired again." instead, please? That's in CompanionScreen.java.

Taming/hiring the companions can also trigger the Best Friends Forever advancement, which says "tame an animal", but I don't think that's super bad. It's just one message, and I think most people would recognize that was just because it was using the tamed animal mechanics under the hood.

I'm playing 1.19.2. This mod is working well for me, and it seems fairly solidly programmed. Thanks for making it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant