Package and SDK updates #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to the latest .NET Core SDK.
Use switch to skip tests. Ensure JSON parse always succeeds between different versions of PowerShell. Use Join-Path to build paths rather than string concatenation. Make "is SDK installed?" more reliable. Get the versions of OpenCover and ReportGenerator by parsing the Directory.Build.props file, rather than hard-coding.
Update .NET Core test SDK and Moq.
Use parameter for analyzer versions as they update in sync. Update analyzer packages. Update SourceLink package. Update ReportGenerator.
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
=======================================
Coverage 89.55% 89.55%
=======================================
Files 19 19
Lines 450 450
Branches 121 121
=======================================
Hits 403 403
Misses 18 18
Partials 29 29Continue to review full report at Codecov.
|
maurofranchi
approved these changes
Jun 2, 2019
AnthonySteele
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Join-Pathto build paths rather than string concatenation.Directory.Build.propsfile, rather than hard-coding.