From 0c8ba4f437126bdbf3a3c697ce9b6fb2822dd6c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Collonval?= Date: Tue, 25 Apr 2023 16:19:56 +0200 Subject: [PATCH 1/2] Make `Token.description` optional for backward compatibility --- packages/coreutils/src/token.ts | 2 +- review/api/coreutils.api.md | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/coreutils/src/token.ts b/packages/coreutils/src/token.ts index 8e4e962d4..2ec309bc0 100644 --- a/packages/coreutils/src/token.ts +++ b/packages/coreutils/src/token.ts @@ -31,7 +31,7 @@ export class Token { /** * Token purpose description. */ - readonly description: string; + readonly description?: string; // FIXME remove `?` for the next major version /** * The human readable name for the token. diff --git a/review/api/coreutils.api.md b/review/api/coreutils.api.md index 8d8816b10..b522feeed 100644 --- a/review/api/coreutils.api.md +++ b/review/api/coreutils.api.md @@ -76,8 +76,7 @@ export class PromiseDelegate { // @public export namespace Random { - const // Warning: (ae-forgotten-export) The symbol "fallbackRandomValues" needs to be exported by the entry point index.d.ts - getRandomValues: typeof fallbackRandomValues; + const getRandomValues: (buffer: Uint8Array) => void; } // @public From a322e1dcbd3c8321a8557b49a8ad79a671486d21 Mon Sep 17 00:00:00 2001 From: "Afshin T. Darian" Date: Tue, 25 Apr 2023 16:36:05 +0100 Subject: [PATCH 2/2] Update API docs --- review/api/coreutils.api.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/review/api/coreutils.api.md b/review/api/coreutils.api.md index b522feeed..d8fcfa10c 100644 --- a/review/api/coreutils.api.md +++ b/review/api/coreutils.api.md @@ -76,7 +76,8 @@ export class PromiseDelegate { // @public export namespace Random { - const getRandomValues: (buffer: Uint8Array) => void; + const // Warning: (ae-forgotten-export) The symbol "fallbackRandomValues" needs to be exported by the entry point index.d.ts + getRandomValues: typeof fallbackRandomValues; } // @public @@ -108,7 +109,7 @@ export type ReadonlyPartialJSONValue = JSONPrimitive | ReadonlyPartialJSONObject // @public export class Token { constructor(name: string, description?: string); - readonly description: string; + readonly description?: string; readonly name: string; }