Menu at the end of the screen renders outside

[hbcarlos]

I'm not sure if this is a bug or not.

Problem

The lumino Menu has an option in its method open to force the position of the menu. The problem is that this option is activated by default when the MenuBar calls this method on one of its child menus.

See:

lumino/packages/widgets/src/menubar.ts

Line 602 in a105b6f

newMenu.open(left, bottom, { forceX: true, forceY: true });

This makes the menu to render outside the viewport when positioning the menu at the right part of the screen.
See the top-right menu on the following image:

After removing the option force:

Proposed Solution

Can we add an option on the constructor of the MenuBar to configure this when creating a new menubar?
Here:
https://github.com/hbcarlos/lumino/blob/a105b6f62d7e630ec2bc0095507fc7547ba29629/packages/widgets/src/menubar.ts#L710

Additional context

[welcome]

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.

You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[fcollonval]

I did something similar for the ContextMenu in https://github.com/jupyterlab/lumino/pull/203/files#diff-3d07da50d2685605691ccf143d09bb0dcf713f3970255e6699c7fd3903d612cb

Don't hesitate to push a PR.

[hbcarlos]

Thx Frédéric!! Opening a PR right now.

[krassowski]

Can we close this one?

[hbcarlos]

Yes, sorry. I forgot!