Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blind users with screenreader read everything in German #14704

Closed
andrii-i opened this issue Jun 17, 2023 · 0 comments · Fixed by #14705
Closed

Blind users with screenreader read everything in German #14704

andrii-i opened this issue Jun 17, 2023 · 0 comments · Fixed by #14705

Comments

@andrii-i
Copy link
Contributor

andrii-i commented Jun 17, 2023

Language

  • Expectation: Language tags are specified on element based on the language the content is being displayed as. If content is in English, needs to be , etc. (WCAG Criteria 3.1.1 (A) and 3.1.2 (AA))
  • Observed:
    • On all pages with my language set to English, lang="default" which reads my content in GERMAN (probably looking at the first 2 letters "de"). Need to have JS that powers this instead change to the proper lang codes.
    • If importing over the Settings Editor to Notebookv7 ever, recommend adding dropdown menu for languages so user only selects from list of languages that are currently supported/installed so bilingual blind users can easily toggle without fear of messing up.

Screenshot 2023-06-16 at 7 50 00 PM

Lang is getting set to default here:

/**
* Load the settings for this extension
*
* @param setting Extension settings
*/
function loadSetting(setting: ISettingRegistry.ISettings): void {
// Read the settings and convert to the correct type
currentLocale = setting.get('locale').composite as string;
}
settings
.load(PLUGIN_ID)
.then(setting => {
// Read the settings
loadSetting(setting);
document.documentElement.lang = (currentLocale ?? '').replace('_', '-');

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant