Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add remote repository" option is enabled when repository is already cloned #886

Closed
tumido opened this issue Feb 26, 2021 · 2 comments
Closed
Labels
bug Good first issue Good first issue to be tackled by new contributors

Comments

@tumido
Copy link

tumido commented Feb 26, 2021

Description

"Add remote repository" option is enabled when repository is already cloned. Trying to add a new repository via the modal fails, because remote is already present.

Reproduce

  1. Clone a git repo to JupyterLab
  2. Click on "Git" menu
  3. Click on "Add Remote Repository" entry in the dropdown
  4. Enter any git repo url
  5. See the error

Expected behavior

The entry is disabled if a repo is already cloned

Context

  • Python package version: 0.30.0b1
  • Extension version:
JupyterLab v3.0.7
/opt/app-root/share/jupyter/labextensions
        jupyterlab_requirements v0.4.6 enabled OK (python, jupyterlab-requirements)
        @jupyter-server/resource-usage v0.5.0 enabled OK (python, jupyter-resource-usage)
        @jupyterlab/git v0.30.0-beta.1 enabled OK (python, jupyterlab-git)
        @krassowski/jupyterlab-lsp v3.3.1 enabled OK (python, jupyterlab_lsp)

Other labextensions (built into JupyterLab)
   app dir: /opt/app-root/share/jupyter/lab
        @elyra/code-snippet-extension v2.0.1 enabled OK
        @elyra/metadata-extension v2.0.1 enabled OK
        @elyra/pipeline-editor-extension v2.0.1 enabled OK
        @elyra/python-editor-extension v2.0.1 enabled OK
        @elyra/theme-extension v2.0.1 enabled OK
        nbdime-jupyterlab v2.1.0-beta.1 enabled OK

Disabled extensions:
@jupyterlab/launcher-extension (all plugins)

  • Git version: 2.27.0

image

image

image

@tumido tumido added the bug label Feb 26, 2021
@fcollonval
Copy link
Member

@tumido Thank you for reporting this issue. It actually should still be enabled - because multiple remote repositories is common when using repository forks. But definitely the extension should support the ability to define the remote name to support that.

@fcollonval fcollonval added the Good first issue Good first issue to be tackled by new contributors label Mar 13, 2021
@fcollonval
Copy link
Member

Resolved by #1146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Good first issue Good first issue to be tackled by new contributors
Projects
None yet
Development

No branches or pull requests

2 participants