Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the 'serverRoot' in jupyter-config-data for tests #6603

Closed
brichet opened this issue Oct 28, 2022 · 1 comment
Closed

Provide the 'serverRoot' in jupyter-config-data for tests #6603

brichet opened this issue Oct 28, 2022 · 1 comment

Comments

@brichet
Copy link
Collaborator

brichet commented Oct 28, 2022

When testing extensions, it can be useful to retrieve the serverRoot from jupyter-config-data script in DOM.
It could be added in page_config with a condition:

notebook/notebook/app.py

Lines 61 to 64 in 2f26f1b

server_root = self.settings.get("server_root_dir", "")
server_root = server_root.replace(os.sep, "/")
server_root = os.path.normpath(os.path.expanduser(server_root))
try:

A simple solution without adding a new option could be to add it if the option exposeAppInBrowser is True (if this is an option for debugging only).

@brichet
Copy link
Collaborator Author

brichet commented Dec 7, 2022

Closing this issue as not planned.
Discussion in #6604

@brichet brichet closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants