Skip to content

Create a Log output widget to log any output from sync messages #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasongrout opened this issue Apr 28, 2017 · 3 comments
Closed

Create a Log output widget to log any output from sync messages #1321

jasongrout opened this issue Apr 28, 2017 · 3 comments
Labels
good first issue resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jasongrout
Copy link
Member

In #1320, we have the problem that a sync message is causing an error that has no place to be displayed in the front end. Until the front end has a place to display unhandled output, perhaps we should create an output widget that stores any output from sync handling.

I think this should be fairly straightforward - create an output widget when widgets are imported, and make sure we are using the output widget when we actually set the state of any widget.

@jasongrout
Copy link
Member Author

jasongrout commented Apr 28, 2017

Incidentally, this may make calling this.touch() on widget views unnecessary to save the changes - maybe now we should always call this.model.save_changes() (but leave in this.touch() for backwards compatibility).

After we fix this issue, let's open another one to audit the this.touch() calls in the javascript, and maybe deprecate the function.

@maxnoy
Copy link
Contributor

maxnoy commented May 11, 2017

This is a temporary solution that would allow capturing widget output until a dedicated output tab for all orphan output was implemented in jupyter-lab and/or jupyter-notebook.

The complexity is that the amount of output could be quite large (messages/errors can be generated for each widget change).

This can be managed by either clearing output for each widget message or by having an adjustable-depth buffer. The former would not work as the output widget utilizes the same widget messaging mechanism, resulting in the messages being cleared immediately by the update on the output widget. And the latter is a substantial amount of work/ux that may as well be redirected to the long-term solution.

@jasongrout
Copy link
Member Author

Agreed! Closing this in favor of the notebook issue!

@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

2 participants