From 735b4623bda9cb67f982eb871d768016803cc43d Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Fri, 10 Dec 2021 18:27:36 +0100 Subject: [PATCH 1/2] Sort the list of workspace package versions --- jupyter_releaser/npm.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jupyter_releaser/npm.py b/jupyter_releaser/npm.py index 6d8be892..d89abb61 100644 --- a/jupyter_releaser/npm.py +++ b/jupyter_releaser/npm.py @@ -149,7 +149,7 @@ def get_package_versions(version): message += f'\nnpm version: {data["name"]}: {npm_version}' if "workspaces" in data: message += "\nnpm workspace versions:" - for path in _get_workspace_packages(data): + for path in sorted(_get_workspace_packages(data)): text = path.joinpath("package.json").read_text(encoding="utf-8") data = json.loads(text) message += f'\n{data["name"]}: {data.get("version", "")}' From 9b51bc882575cbd8d7602fe71e9fd992259e6f1d Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Mon, 13 Dec 2021 10:42:14 +0100 Subject: [PATCH 2/2] Sort in _get_workspace_packages --- jupyter_releaser/npm.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jupyter_releaser/npm.py b/jupyter_releaser/npm.py index d89abb61..d7b2cc03 100644 --- a/jupyter_releaser/npm.py +++ b/jupyter_releaser/npm.py @@ -149,7 +149,7 @@ def get_package_versions(version): message += f'\nnpm version: {data["name"]}: {npm_version}' if "workspaces" in data: message += "\nnpm workspace versions:" - for path in sorted(_get_workspace_packages(data)): + for path in _get_workspace_packages(data): text = path.joinpath("package.json").read_text(encoding="utf-8") data = json.loads(text) message += f'\n{data["name"]}: {data.get("version", "")}' @@ -199,4 +199,4 @@ def _get_workspace_packages(data): continue paths.append(sub_package) - return paths + return sorted(paths)