Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using after-git-prep in Draft Changelog workflows #67

Closed
afshin opened this issue Jul 12, 2021 · 0 comments · Fixed by #85
Closed

Using after-git-prep in Draft Changelog workflows #67

afshin opened this issue Jul 12, 2021 · 0 comments · Fixed by #85
Labels
bug Something isn't working
Milestone
0.3

Comments

@afshin
Copy link
Contributor

afshin commented Jul 12, 2021 •
edited
Loading

We can’t yet use after-git-prep in Draft Changelog workflows because we don’t have the remote repo’s metadata until after the git checkout.  We need to re-read the config before running the after hooks.
@afshin afshin added the enhancement New feature or request label Jul 12, 2021
@blink1073 blink1073 added this to the 0.1 milestone Jul 12, 2021
@blink1073 blink1073 added bug Something isn't working and removed enhancement New feature or request labels Jul 12, 2021
@blink1073 blink1073 modified the milestones: 0.1, 0.2 Jul 16, 2021
@blink1073 blink1073 mentioned this issue Jul 21, 2021
Merged
@blink1073 blink1073 modified the milestones: 0.2, 0.3 Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.3
Development

Successfully merging a pull request may close this issue.

Allow after-prep-git to work blink1073/jupyter_releaser
2 participants
@afshin @blink1073