-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to allow for non-admin user execution #555
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
@blink1073 Would you be able to give some thoughts on this? I can implement the latter proposed solution pretty easily and quickly if you approve of it. |
Hi @ElioDiNino, I think an |
Okay, thanks! I will create a PR for that soon |
Relevant changes in #559 |
Resolved with the latest release 🎉 |
Problem
I have modified the default jupyter_releaser workflow such that a GitHub app token is used instead of a user token. However, within the
prepare_environment
function, a check is made through the GitHub API to see if the user is a repo admin (exact lines here). This is an issue since even though the token is setup such that all the necessary permissions are granted, this arbitrary check blocks non-admin repo members from making releases.I tried getting around this by modifying the actions with
GITHUB_ACTOR
and setting the value to our bot username, but the GitHub app isn't treated as a user by the API (understandably) and so it fails.Proposed Solution
I think the check should either change to validate the required permissions of the token, or for an easier workaround, be able to be turned off through a flag/environment variable (e.g.
RH_ADMIN_CHECK=false
).Additional context
The text was updated successfully, but these errors were encountered: