Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install package in venv #440

Closed
blink1073 opened this issue Oct 11, 2022 · 2 comments · Fixed by #449
Closed

Install package in venv #440

blink1073 opened this issue Oct 11, 2022 · 2 comments · Fixed by #449
Labels
bug Something isn't working

Comments

@blink1073
Copy link
Contributor

We should consider "some isolation when installing the package with pip install -q -e ".[dev,test]", since there might be some dependencies in the dev or test extras that could conflict with the latest jupyter_releaser (or one of its dependencies)."

#438 (comment)

@blink1073 blink1073 added the bug Something isn't working label Oct 11, 2022
@blink1073
Copy link
Contributor Author

I'm not sure we even need to install the python package at all in prep_git. We could try removing it, what do you think @jtpio?

@jtpio
Copy link
Member

jtpio commented Oct 17, 2022

Removing the install of the python packages sounds good, or at least worth trying for v2.

Probably there could be some dev packages that are used to bump the version for example. But they could also be installed in one of the releaser hooks as well, for example in after-prep-git or before-bump-version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants