Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full release fails #421

Closed
3coins opened this issue Oct 4, 2022 · 6 comments · Fixed by #427 or #435
Closed

Full release fails #421

3coins opened this issue Oct 4, 2022 · 6 comments · Fixed by #427 or #435
Labels
bug Something isn't working

Comments

@3coins
Copy link

3coins commented Oct 4, 2022

Description

Full release is failing for jupyter-server/jupyter-scheduler even though the Prep Release has created a correct Draft release. The error displayed refers to this message.

From https://github.com/3coins/jupyter_releaser
 * branch            main       -> FETCH_HEAD
4aa69439e685654f36cebcd14f6c11fbcdfc930b
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.10.7/x[64](https://github.com/3coins/jupyter_releaser/actions/runs/3184091969/jobs/5192100306#step:4:67)/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/opt/hostedtoolcache/Python/3.10.7/x64/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/runner/work/jupyter_releaser/jupyter_releaser/jupyter_releaser/actions/populate_release.py", line 34, in <module>
    ensure_sha()
Prepare Environment
    raise ValueError(f"{branch} is ahead of expected sha {current_sha}")
ValueError: main is ahead of expected sha 5fd185[69](https://github.com/3coins/jupyter_releaser/actions/runs/3184091969/jobs/5192100306#step:4:72)10bc2d90bb5c1c24cdfd06c6e351e160

The sha referred to the error message seems correct, as per the changelog here, so not sure what is expected.
jupyter-server/jupyter-scheduler@v0.3.1...5fd1856

Context

Prep Release Run
https://github.com/3coins/jupyter_releaser/actions/runs/3184039435

Full Release Run
https://github.com/3coins/jupyter_releaser/actions/runs/3184091969/jobs/5192100306

@3coins 3coins added the bug Something isn't working label Oct 4, 2022
@welcome
Copy link

welcome bot commented Oct 4, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@blink1073
Copy link
Contributor

That error is most likely due to merging a PR between when prep release and publish release were run.

@3coins
Copy link
Author

3coins commented Oct 4, 2022

@blink1073 That’s what I thought initially, but this was not the case. This is the 2nd time I saw this error and had to do a manual release.

@blink1073
Copy link
Contributor

Nothing is jumping out at me. I'm adding more debugging in #422

@blink1073
Copy link
Contributor

I pushed a release with the extra debugging added.

@blink1073
Copy link
Contributor

This is still not working, we need to make ensure-sha a CLI command and have it run from the checkout directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants