[DEV] use latest jupyterlab APIs #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
commented
Oct 17, 2020
| shim(/@phosphor\/collections\/lib\/(bplustree).*/), | ||
| shim(/@phosphor\/(dragdrop|commands).*/), | ||
| shim(/@lumino\/collections\/lib\/(bplustree).*/), | ||
| shim(/@lumino\/(dragdrop|commands).*/), |
There was a problem hiding this comment.
The shims will need revisiting, as the bundle got even bigger again!
not ready for webpack 5, but everything else is updated
mainly: - lumino imports - fill out partial serverSettings with makeSettings - opt-in to appendToken (previously default behavior) - switch from Session.startNew to KernelManager().startNew
minrk
force-pushed
the
jupyterlab-bumps
branch
from
18d18c4 to
4abe8bc
Compare
it's huge, but seems required for widget-output at least
minrk
force-pushed
the
jupyterlab-bumps
branch
from
4abe8bc to
e2886e6
Compare
minrk
changed the title
|
This is working, and should no longer conflict with sprint contributions |
|
@minrk will this be an issue if JupyterLab isn't installed on the particular binder instance that a person requests? E.g. I think that Binder ships with JupyterLab 2.X right now, and I dunno when it'll switch to 3.x |
|
It shouldn't. This only means the jupyterlab javascript APIs that are pulled in as part of thebe itself. It should not be sensitive to the server-side version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates everything except for webpack 5, which doesn't seem to work yet. This uses the packages from the latest jupyterlab 3.0 release candidate.
The changes are relatively small:
KernelManager().startNewinstead ofSession.startNewappendTokenbehavior is now opt-in instead of the default. This is required for cross-origin use cases like oursThis seems to work just fine, but I don't want to introduce any conflicts with what other sprinters are working on