Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properties dropped by transformer #46

Closed
nrbgt opened this issue Nov 13, 2020 · 0 comments · Fixed by #47
Closed

Properties dropped by transformer #46

nrbgt opened this issue Nov 13, 2020 · 0 comments · Fixed by #47
Labels
bug Something isn't working

Comments

@nrbgt
Copy link
Contributor

nrbgt commented Nov 13, 2020

With master, it looks like adding a "properties": {"cssClasses": "custom-class-from-data-foo"}} to an edge does not result in it getting added to the DOM.

We probably just need to initialize all of the properties from the data, rather than None, and special-case cssClasses.

This seems worthwhile to test.
@nrbgt nrbgt added the bug Something isn't working label Nov 13, 2020
@nrbgt nrbgt mentioned this issue Nov 13, 2020
Merged
7 tasks
nrbgt added a commit to nrbgt/ipyelk that referenced this issue Nov 13, 2020
@nrbgt
Merge remote-tracking branch 'upstream/master' into fix-jupyrdfgh-46-…
eb53cf7 
…tx-properties
@nrbgt nrbgt closed this as completed in #47 Nov 16, 2020
@dfreeman06 dfreeman06 mentioned this issue Dec 3, 2020
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Normalize and test transformer handling of custom properties nrbgt/ipyelk
1 participant
@nrbgt