Classes annotated with @RunWith(Suite.class) do not need to be public. #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
approved these changes
Jan 9, 2017
stefanbirkner
requested changes
Jan 17, 2017
There was a problem hiding this comment.
Could you please add to the commit message that this regression was introduced by 1d97da7. Everything else is fine.
This fixes a regression in JUnit 4.12 introduced by junit-team@1d97da7.
kcooney
force-pushed
the
non-public-suite-class
branch
from
8958635 to
1faa552
Compare
|
I updated the comment message. @stefanbirkner if the new commit message looks fine, please merge. |
sebasjm
pushed a commit
to sebasjm/junit4
that referenced
this pull request
Mar 11, 2018
junit-team#1408) This fixes a regression in JUnit 4.12 introduced by junit-team@1d97da7.
aristotle0x01
pushed a commit
to aristotle0x01/junit4
that referenced
this pull request
Jun 27, 2022
junit-team#1408) This fixes a regression in JUnit 4.12 introduced by junit-team@1d97da7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression in JUnit 4.12.