Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code not compatible Python version below 3.10 #2

Open
nestorcarmona opened this issue Apr 1, 2023 · 4 comments
Open

Code not compatible Python version below 3.10 #2

nestorcarmona opened this issue Apr 1, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@nestorcarmona
Copy link
Collaborator

nestorcarmona commented Apr 1, 2023

This line
transform_name: str | None = None found in utils.py
works only for python 3.10+

fix the typing to allow for older versions or create default conda environment to load (docker, etc. tu connais mieux que moi mdr)

@nestorcarmona nestorcarmona added the bug Something isn't working label Apr 1, 2023
@julien-blanchon
Copy link
Owner

For retrocompatiblity we can use Optional from typing library with

from typing import Optional
...
transform_name: Optional[str] = None

But to be honest I don't care about peaple still using python older than 3.10 😂
I prefer by far the | union of python 3.10 than the Optional type

@julien-blanchon
Copy link
Owner

julien-blanchon commented Apr 1, 2023

I can add a .devcontainer (see Create a Dev Container ), but this overkill for a such little project

@nestorcarmona
Copy link
Collaborator Author

For retrocompatiblity we can use Optional from typing library with

from typing import Optional
...
transform_name: Optional[str] = None

But to be honest I don't care about peaple still using python older than 3.10 😂 I prefer by far the | union of python 3.10 than the Optional type

this is the perfect and only answer

@nestorcarmona
Copy link
Collaborator Author

I can add a .devcontainer (see Create a Dev Container ), but this overkill for a such little project

I can try just for fun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants