Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-grader does not test for missing upload #20

Open
Sardtok opened this issue Aug 2, 2014 · 0 comments
Open

Auto-grader does not test for missing upload #20

Sardtok opened this issue Aug 2, 2014 · 0 comments

Comments

@Sardtok
Copy link

Sardtok commented Aug 2, 2014

The assignment says that if a video has not yet been uploaded, but meta-data has been created, it should respond with a 404 response code.

If no mpeg data has been uploaded for the specified video, then the server should return a 404 status code.

However, Spring does not by default associate a 404 response with the FileNotFoundException, which is thrown by the VideoFileManager. Therefore a 500 response will be generated if one doesn't specifically handle this with a handler or try-catch. The tests do not check that they get a 404 for missing uploads, only for invalid video IDs.

I suggest adding an additional test to future iterations of the course, to ensure the programmer has properly handled this either by adding a handler or by try-catching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant