diff --git a/cmd/headscale/cli/api_key.go b/cmd/headscale/cli/api_key.go index 37ef4235141..14293aee477 100644 --- a/cmd/headscale/cli/api_key.go +++ b/cmd/headscale/cli/api_key.go @@ -67,7 +67,7 @@ var listAPIKeys = &cobra.Command{ } if output != "" { - SuccessOutput(response.ApiKeys, "", output) + SuccessOutput(response.GetApiKeys(), "", output) return } @@ -75,11 +75,11 @@ var listAPIKeys = &cobra.Command{ tableData := pterm.TableData{ {"ID", "Prefix", "Expiration", "Created"}, } - for _, key := range response.ApiKeys { + for _, key := range response.GetApiKeys() { expiration := "-" if key.GetExpiration() != nil { - expiration = ColourTime(key.Expiration.AsTime()) + expiration = ColourTime(key.GetExpiration().AsTime()) } tableData = append(tableData, []string{ @@ -155,7 +155,7 @@ If you loose a key, create a new one and revoke (expire) the old one.`, return } - SuccessOutput(response.ApiKey, response.ApiKey, output) + SuccessOutput(response.GetApiKey(), response.GetApiKey(), output) }, } diff --git a/cmd/headscale/cli/debug.go b/cmd/headscale/cli/debug.go index c77aeef3049..054fc07fc39 100644 --- a/cmd/headscale/cli/debug.go +++ b/cmd/headscale/cli/debug.go @@ -135,6 +135,6 @@ var createNodeCmd = &cobra.Command{ return } - SuccessOutput(response.Node, "Node created", output) + SuccessOutput(response.GetNode(), "Node created", output) }, } diff --git a/cmd/headscale/cli/nodes.go b/cmd/headscale/cli/nodes.go index 687ec93cef4..b1632d6c5b9 100644 --- a/cmd/headscale/cli/nodes.go +++ b/cmd/headscale/cli/nodes.go @@ -152,8 +152,8 @@ var registerNodeCmd = &cobra.Command{ } SuccessOutput( - response.Node, - fmt.Sprintf("Node %s registered", response.Node.GivenName), output) + response.GetNode(), + fmt.Sprintf("Node %s registered", response.GetNode().GetGivenName()), output) }, } @@ -196,12 +196,12 @@ var listNodesCmd = &cobra.Command{ } if output != "" { - SuccessOutput(response.Nodes, "", output) + SuccessOutput(response.GetNodes(), "", output) return } - tableData, err := nodesToPtables(user, showTags, response.Nodes) + tableData, err := nodesToPtables(user, showTags, response.GetNodes()) if err != nil { ErrorOutput(err, fmt.Sprintf("Error converting to table: %s", err), output) @@ -262,7 +262,7 @@ var expireNodeCmd = &cobra.Command{ return } - SuccessOutput(response.Node, "Node expired", output) + SuccessOutput(response.GetNode(), "Node expired", output) }, } @@ -310,7 +310,7 @@ var renameNodeCmd = &cobra.Command{ return } - SuccessOutput(response.Node, "Node renamed", output) + SuccessOutput(response.GetNode(), "Node renamed", output) }, } @@ -364,7 +364,7 @@ var deleteNodeCmd = &cobra.Command{ prompt := &survey.Confirm{ Message: fmt.Sprintf( "Do you want to remove the node %s?", - getResponse.GetNode().Name, + getResponse.GetNode().GetName(), ), } err = survey.AskOne(prompt, &confirm) @@ -473,7 +473,7 @@ var moveNodeCmd = &cobra.Command{ return } - SuccessOutput(moveResponse.Node, "Node moved to another user", output) + SuccessOutput(moveResponse.GetNode(), "Node moved to another user", output) }, } @@ -507,21 +507,21 @@ func nodesToPtables( for _, node := range nodes { var ephemeral bool - if node.PreAuthKey != nil && node.PreAuthKey.Ephemeral { + if node.GetPreAuthKey() != nil && node.GetPreAuthKey().GetEphemeral() { ephemeral = true } var lastSeen time.Time var lastSeenTime string - if node.LastSeen != nil { - lastSeen = node.LastSeen.AsTime() + if node.GetLastSeen() != nil { + lastSeen = node.GetLastSeen().AsTime() lastSeenTime = lastSeen.Format("2006-01-02 15:04:05") } var expiry time.Time var expiryTime string - if node.Expiry != nil { - expiry = node.Expiry.AsTime() + if node.GetExpiry() != nil { + expiry = node.GetExpiry().AsTime() expiryTime = expiry.Format("2006-01-02 15:04:05") } else { expiryTime = "N/A" @@ -529,7 +529,7 @@ func nodesToPtables( var machineKey key.MachinePublic err := machineKey.UnmarshalText( - []byte(node.MachineKey), + []byte(node.GetMachineKey()), ) if err != nil { machineKey = key.MachinePublic{} @@ -537,14 +537,14 @@ func nodesToPtables( var nodeKey key.NodePublic err = nodeKey.UnmarshalText( - []byte(node.NodeKey), + []byte(node.GetNodeKey()), ) if err != nil { return nil, err } var online string - if node.Online { + if node.GetOnline() { online = pterm.LightGreen("online") } else { online = pterm.LightRed("offline") @@ -558,36 +558,36 @@ func nodesToPtables( } var forcedTags string - for _, tag := range node.ForcedTags { + for _, tag := range node.GetForcedTags() { forcedTags += "," + tag } forcedTags = strings.TrimLeft(forcedTags, ",") var invalidTags string - for _, tag := range node.InvalidTags { - if !contains(node.ForcedTags, tag) { + for _, tag := range node.GetInvalidTags() { + if !contains(node.GetForcedTags(), tag) { invalidTags += "," + pterm.LightRed(tag) } } invalidTags = strings.TrimLeft(invalidTags, ",") var validTags string - for _, tag := range node.ValidTags { - if !contains(node.ForcedTags, tag) { + for _, tag := range node.GetValidTags() { + if !contains(node.GetForcedTags(), tag) { validTags += "," + pterm.LightGreen(tag) } } validTags = strings.TrimLeft(validTags, ",") var user string - if currentUser == "" || (currentUser == node.User.Name) { - user = pterm.LightMagenta(node.User.Name) + if currentUser == "" || (currentUser == node.GetUser().GetName()) { + user = pterm.LightMagenta(node.GetUser().GetName()) } else { // Shared into this user - user = pterm.LightYellow(node.User.Name) + user = pterm.LightYellow(node.GetUser().GetName()) } var IPV4Address string var IPV6Address string - for _, addr := range node.IpAddresses { + for _, addr := range node.GetIpAddresses() { if netip.MustParseAddr(addr).Is4() { IPV4Address = addr } else { @@ -596,8 +596,8 @@ func nodesToPtables( } nodeData := []string{ - strconv.FormatUint(node.Id, util.Base10), - node.Name, + strconv.FormatUint(node.GetId(), util.Base10), + node.GetName(), node.GetGivenName(), machineKey.ShortString(), nodeKey.ShortString(), diff --git a/cmd/headscale/cli/preauthkeys.go b/cmd/headscale/cli/preauthkeys.go index 7eb19560ca9..c8dd2adcb2f 100644 --- a/cmd/headscale/cli/preauthkeys.go +++ b/cmd/headscale/cli/preauthkeys.go @@ -84,7 +84,7 @@ var listPreAuthKeys = &cobra.Command{ } if output != "" { - SuccessOutput(response.PreAuthKeys, "", output) + SuccessOutput(response.GetPreAuthKeys(), "", output) return } @@ -101,10 +101,10 @@ var listPreAuthKeys = &cobra.Command{ "Tags", }, } - for _, key := range response.PreAuthKeys { + for _, key := range response.GetPreAuthKeys() { expiration := "-" if key.GetExpiration() != nil { - expiration = ColourTime(key.Expiration.AsTime()) + expiration = ColourTime(key.GetExpiration().AsTime()) } var reusable string @@ -116,7 +116,7 @@ var listPreAuthKeys = &cobra.Command{ aclTags := "" - for _, tag := range key.AclTags { + for _, tag := range key.GetAclTags() { aclTags += "," + tag } @@ -214,7 +214,7 @@ var createPreAuthKeyCmd = &cobra.Command{ return } - SuccessOutput(response.PreAuthKey, response.PreAuthKey.Key, output) + SuccessOutput(response.GetPreAuthKey(), response.GetPreAuthKey().GetKey(), output) }, } diff --git a/cmd/headscale/cli/routes.go b/cmd/headscale/cli/routes.go index 1872cbc7803..86ef295c094 100644 --- a/cmd/headscale/cli/routes.go +++ b/cmd/headscale/cli/routes.go @@ -87,12 +87,12 @@ var listRoutesCmd = &cobra.Command{ } if output != "" { - SuccessOutput(response.Routes, "", output) + SuccessOutput(response.GetRoutes(), "", output) return } - routes = response.Routes + routes = response.GetRoutes() } else { response, err := client.GetNodeRoutes(ctx, &v1.GetNodeRoutesRequest{ NodeId: machineID, @@ -108,12 +108,12 @@ var listRoutesCmd = &cobra.Command{ } if output != "" { - SuccessOutput(response.Routes, "", output) + SuccessOutput(response.GetRoutes(), "", output) return } - routes = response.Routes + routes = response.GetRoutes() } tableData := routesToPtables(routes) @@ -271,25 +271,25 @@ func routesToPtables(routes []*v1.Route) pterm.TableData { for _, route := range routes { var isPrimaryStr string - prefix, err := netip.ParsePrefix(route.Prefix) + prefix, err := netip.ParsePrefix(route.GetPrefix()) if err != nil { - log.Printf("Error parsing prefix %s: %s", route.Prefix, err) + log.Printf("Error parsing prefix %s: %s", route.GetPrefix(), err) continue } if prefix == types.ExitRouteV4 || prefix == types.ExitRouteV6 { isPrimaryStr = "-" } else { - isPrimaryStr = strconv.FormatBool(route.IsPrimary) + isPrimaryStr = strconv.FormatBool(route.GetIsPrimary()) } tableData = append(tableData, []string{ - strconv.FormatUint(route.Id, Base10), - route.Node.GivenName, - route.Prefix, - strconv.FormatBool(route.Advertised), - strconv.FormatBool(route.Enabled), + strconv.FormatUint(route.GetId(), Base10), + route.GetNode().GetGivenName(), + route.GetPrefix(), + strconv.FormatBool(route.GetAdvertised()), + strconv.FormatBool(route.GetEnabled()), isPrimaryStr, }) } diff --git a/cmd/headscale/cli/users.go b/cmd/headscale/cli/users.go index 3132e99503a..e6463d6f8db 100644 --- a/cmd/headscale/cli/users.go +++ b/cmd/headscale/cli/users.go @@ -67,7 +67,7 @@ var createUserCmd = &cobra.Command{ return } - SuccessOutput(response.User, "User created", output) + SuccessOutput(response.GetUser(), "User created", output) }, } @@ -169,7 +169,7 @@ var listUsersCmd = &cobra.Command{ } if output != "" { - SuccessOutput(response.Users, "", output) + SuccessOutput(response.GetUsers(), "", output) return } @@ -236,6 +236,6 @@ var renameUserCmd = &cobra.Command{ return } - SuccessOutput(response.User, "User renamed", output) + SuccessOutput(response.GetUser(), "User renamed", output) }, } diff --git a/hscontrol/auth.go b/hscontrol/auth.go index 26bb6b5ba7c..5022f65ac2e 100644 --- a/hscontrol/auth.go +++ b/hscontrol/auth.go @@ -301,7 +301,7 @@ func (h *Headscale) handleAuthKey( return } - aclTags := pak.Proto().AclTags + aclTags := pak.Proto().GetAclTags() if len(aclTags) > 0 { // This conditional preserves the existing behaviour, although SaaS would reset the tags on auth-key login err = h.db.SetTags(node, aclTags) @@ -342,7 +342,7 @@ func (h *Headscale) handleAuthKey( NodeKey: nodeKey, LastSeen: &now, AuthKeyID: uint(pak.ID), - ForcedTags: pak.Proto().AclTags, + ForcedTags: pak.Proto().GetAclTags(), } node, err = h.db.RegisterNode( diff --git a/hscontrol/db/preauth_keys_test.go b/hscontrol/db/preauth_keys_test.go index 52b837c7723..df9c2a1089d 100644 --- a/hscontrol/db/preauth_keys_test.go +++ b/hscontrol/db/preauth_keys_test.go @@ -198,5 +198,5 @@ func (*Suite) TestPreAuthKeyACLTags(c *check.C) { listedPaks, err := db.ListPreAuthKeys("test8") c.Assert(err, check.IsNil) - c.Assert(listedPaks[0].Proto().AclTags, check.DeepEquals, tags) + c.Assert(listedPaks[0].Proto().GetAclTags(), check.DeepEquals, tags) } diff --git a/integration/cli_test.go b/integration/cli_test.go index ed1b3fc8af9..6e7333ff60f 100644 --- a/integration/cli_test.go +++ b/integration/cli_test.go @@ -60,7 +60,7 @@ func TestUserCommand(t *testing.T) { ) assertNoErr(t, err) - result := []string{listUsers[0].Name, listUsers[1].Name} + result := []string{listUsers[0].GetName(), listUsers[1].GetName()} sort.Strings(result) assert.Equal( @@ -95,7 +95,7 @@ func TestUserCommand(t *testing.T) { ) assertNoErr(t, err) - result = []string{listAfterRenameUsers[0].Name, listAfterRenameUsers[1].Name} + result = []string{listAfterRenameUsers[0].GetName(), listAfterRenameUsers[1].GetName()} sort.Strings(result) assert.Equal( @@ -177,29 +177,29 @@ func TestPreAuthKeyCommand(t *testing.T) { assert.Equal( t, - []string{keys[0].Id, keys[1].Id, keys[2].Id}, - []string{listedPreAuthKeys[1].Id, listedPreAuthKeys[2].Id, listedPreAuthKeys[3].Id}, + []string{keys[0].GetId(), keys[1].GetId(), keys[2].GetId()}, + []string{listedPreAuthKeys[1].GetId(), listedPreAuthKeys[2].GetId(), listedPreAuthKeys[3].GetId()}, ) - assert.NotEmpty(t, listedPreAuthKeys[1].Key) - assert.NotEmpty(t, listedPreAuthKeys[2].Key) - assert.NotEmpty(t, listedPreAuthKeys[3].Key) + assert.NotEmpty(t, listedPreAuthKeys[1].GetKey()) + assert.NotEmpty(t, listedPreAuthKeys[2].GetKey()) + assert.NotEmpty(t, listedPreAuthKeys[3].GetKey()) - assert.True(t, listedPreAuthKeys[1].Expiration.AsTime().After(time.Now())) - assert.True(t, listedPreAuthKeys[2].Expiration.AsTime().After(time.Now())) - assert.True(t, listedPreAuthKeys[3].Expiration.AsTime().After(time.Now())) + assert.True(t, listedPreAuthKeys[1].GetExpiration().AsTime().After(time.Now())) + assert.True(t, listedPreAuthKeys[2].GetExpiration().AsTime().After(time.Now())) + assert.True(t, listedPreAuthKeys[3].GetExpiration().AsTime().After(time.Now())) assert.True( t, - listedPreAuthKeys[1].Expiration.AsTime().Before(time.Now().Add(time.Hour*26)), + listedPreAuthKeys[1].GetExpiration().AsTime().Before(time.Now().Add(time.Hour*26)), ) assert.True( t, - listedPreAuthKeys[2].Expiration.AsTime().Before(time.Now().Add(time.Hour*26)), + listedPreAuthKeys[2].GetExpiration().AsTime().Before(time.Now().Add(time.Hour*26)), ) assert.True( t, - listedPreAuthKeys[3].Expiration.AsTime().Before(time.Now().Add(time.Hour*26)), + listedPreAuthKeys[3].GetExpiration().AsTime().Before(time.Now().Add(time.Hour*26)), ) for index := range listedPreAuthKeys { @@ -207,7 +207,7 @@ func TestPreAuthKeyCommand(t *testing.T) { continue } - assert.Equal(t, listedPreAuthKeys[index].AclTags, []string{"tag:test1", "tag:test2"}) + assert.Equal(t, listedPreAuthKeys[index].GetAclTags(), []string{"tag:test1", "tag:test2"}) } // Test key expiry @@ -218,7 +218,7 @@ func TestPreAuthKeyCommand(t *testing.T) { "--user", user, "expire", - listedPreAuthKeys[1].Key, + listedPreAuthKeys[1].GetKey(), }, ) assertNoErr(t, err) @@ -239,9 +239,9 @@ func TestPreAuthKeyCommand(t *testing.T) { ) assertNoErr(t, err) - assert.True(t, listedPreAuthKeysAfterExpire[1].Expiration.AsTime().Before(time.Now())) - assert.True(t, listedPreAuthKeysAfterExpire[2].Expiration.AsTime().After(time.Now())) - assert.True(t, listedPreAuthKeysAfterExpire[3].Expiration.AsTime().After(time.Now())) + assert.True(t, listedPreAuthKeysAfterExpire[1].GetExpiration().AsTime().Before(time.Now())) + assert.True(t, listedPreAuthKeysAfterExpire[2].GetExpiration().AsTime().After(time.Now())) + assert.True(t, listedPreAuthKeysAfterExpire[3].GetExpiration().AsTime().After(time.Now())) } func TestPreAuthKeyCommandWithoutExpiry(t *testing.T) { @@ -300,10 +300,10 @@ func TestPreAuthKeyCommandWithoutExpiry(t *testing.T) { // There is one key created by "scenario.CreateHeadscaleEnv" assert.Len(t, listedPreAuthKeys, 2) - assert.True(t, listedPreAuthKeys[1].Expiration.AsTime().After(time.Now())) + assert.True(t, listedPreAuthKeys[1].GetExpiration().AsTime().After(time.Now())) assert.True( t, - listedPreAuthKeys[1].Expiration.AsTime().Before(time.Now().Add(time.Minute*70)), + listedPreAuthKeys[1].GetExpiration().AsTime().Before(time.Now().Add(time.Minute*70)), ) } @@ -442,9 +442,9 @@ func TestEnablingRoutes(t *testing.T) { assert.Len(t, routes, 3) for _, route := range routes { - assert.Equal(t, route.Advertised, true) - assert.Equal(t, route.Enabled, false) - assert.Equal(t, route.IsPrimary, false) + assert.Equal(t, route.GetAdvertised(), true) + assert.Equal(t, route.GetEnabled(), false) + assert.Equal(t, route.GetIsPrimary(), false) } for _, route := range routes { @@ -454,7 +454,7 @@ func TestEnablingRoutes(t *testing.T) { "routes", "enable", "--route", - strconv.Itoa(int(route.Id)), + strconv.Itoa(int(route.GetId())), }) assertNoErr(t, err) } @@ -475,12 +475,12 @@ func TestEnablingRoutes(t *testing.T) { assert.Len(t, enablingRoutes, 3) for _, route := range enablingRoutes { - assert.Equal(t, route.Advertised, true) - assert.Equal(t, route.Enabled, true) - assert.Equal(t, route.IsPrimary, true) + assert.Equal(t, route.GetAdvertised(), true) + assert.Equal(t, route.GetEnabled(), true) + assert.Equal(t, route.GetIsPrimary(), true) } - routeIDToBeDisabled := enablingRoutes[0].Id + routeIDToBeDisabled := enablingRoutes[0].GetId() _, err = headscale.Execute( []string{ @@ -507,14 +507,14 @@ func TestEnablingRoutes(t *testing.T) { assertNoErr(t, err) for _, route := range disablingRoutes { - assert.Equal(t, true, route.Advertised) + assert.Equal(t, true, route.GetAdvertised()) - if route.Id == routeIDToBeDisabled { - assert.Equal(t, route.Enabled, false) - assert.Equal(t, route.IsPrimary, false) + if route.GetId() == routeIDToBeDisabled { + assert.Equal(t, route.GetEnabled(), false) + assert.Equal(t, route.GetIsPrimary(), false) } else { - assert.Equal(t, route.Enabled, true) - assert.Equal(t, route.IsPrimary, true) + assert.Equal(t, route.GetEnabled(), true) + assert.Equal(t, route.GetIsPrimary(), true) } } } @@ -577,43 +577,43 @@ func TestApiKeyCommand(t *testing.T) { assert.Len(t, listedAPIKeys, 5) - assert.Equal(t, uint64(1), listedAPIKeys[0].Id) - assert.Equal(t, uint64(2), listedAPIKeys[1].Id) - assert.Equal(t, uint64(3), listedAPIKeys[2].Id) - assert.Equal(t, uint64(4), listedAPIKeys[3].Id) - assert.Equal(t, uint64(5), listedAPIKeys[4].Id) + assert.Equal(t, uint64(1), listedAPIKeys[0].GetId()) + assert.Equal(t, uint64(2), listedAPIKeys[1].GetId()) + assert.Equal(t, uint64(3), listedAPIKeys[2].GetId()) + assert.Equal(t, uint64(4), listedAPIKeys[3].GetId()) + assert.Equal(t, uint64(5), listedAPIKeys[4].GetId()) - assert.NotEmpty(t, listedAPIKeys[0].Prefix) - assert.NotEmpty(t, listedAPIKeys[1].Prefix) - assert.NotEmpty(t, listedAPIKeys[2].Prefix) - assert.NotEmpty(t, listedAPIKeys[3].Prefix) - assert.NotEmpty(t, listedAPIKeys[4].Prefix) + assert.NotEmpty(t, listedAPIKeys[0].GetPrefix()) + assert.NotEmpty(t, listedAPIKeys[1].GetPrefix()) + assert.NotEmpty(t, listedAPIKeys[2].GetPrefix()) + assert.NotEmpty(t, listedAPIKeys[3].GetPrefix()) + assert.NotEmpty(t, listedAPIKeys[4].GetPrefix()) - assert.True(t, listedAPIKeys[0].Expiration.AsTime().After(time.Now())) - assert.True(t, listedAPIKeys[1].Expiration.AsTime().After(time.Now())) - assert.True(t, listedAPIKeys[2].Expiration.AsTime().After(time.Now())) - assert.True(t, listedAPIKeys[3].Expiration.AsTime().After(time.Now())) - assert.True(t, listedAPIKeys[4].Expiration.AsTime().After(time.Now())) + assert.True(t, listedAPIKeys[0].GetExpiration().AsTime().After(time.Now())) + assert.True(t, listedAPIKeys[1].GetExpiration().AsTime().After(time.Now())) + assert.True(t, listedAPIKeys[2].GetExpiration().AsTime().After(time.Now())) + assert.True(t, listedAPIKeys[3].GetExpiration().AsTime().After(time.Now())) + assert.True(t, listedAPIKeys[4].GetExpiration().AsTime().After(time.Now())) assert.True( t, - listedAPIKeys[0].Expiration.AsTime().Before(time.Now().Add(time.Hour*26)), + listedAPIKeys[0].GetExpiration().AsTime().Before(time.Now().Add(time.Hour*26)), ) assert.True( t, - listedAPIKeys[1].Expiration.AsTime().Before(time.Now().Add(time.Hour*26)), + listedAPIKeys[1].GetExpiration().AsTime().Before(time.Now().Add(time.Hour*26)), ) assert.True( t, - listedAPIKeys[2].Expiration.AsTime().Before(time.Now().Add(time.Hour*26)), + listedAPIKeys[2].GetExpiration().AsTime().Before(time.Now().Add(time.Hour*26)), ) assert.True( t, - listedAPIKeys[3].Expiration.AsTime().Before(time.Now().Add(time.Hour*26)), + listedAPIKeys[3].GetExpiration().AsTime().Before(time.Now().Add(time.Hour*26)), ) assert.True( t, - listedAPIKeys[4].Expiration.AsTime().Before(time.Now().Add(time.Hour*26)), + listedAPIKeys[4].GetExpiration().AsTime().Before(time.Now().Add(time.Hour*26)), ) expiredPrefixes := make(map[string]bool) @@ -626,12 +626,12 @@ func TestApiKeyCommand(t *testing.T) { "apikeys", "expire", "--prefix", - listedAPIKeys[idx].Prefix, + listedAPIKeys[idx].GetPrefix(), }, ) assert.Nil(t, err) - expiredPrefixes[listedAPIKeys[idx].Prefix] = true + expiredPrefixes[listedAPIKeys[idx].GetPrefix()] = true } var listedAfterExpireAPIKeys []v1.ApiKey @@ -648,17 +648,17 @@ func TestApiKeyCommand(t *testing.T) { assert.Nil(t, err) for index := range listedAfterExpireAPIKeys { - if _, ok := expiredPrefixes[listedAfterExpireAPIKeys[index].Prefix]; ok { + if _, ok := expiredPrefixes[listedAfterExpireAPIKeys[index].GetPrefix()]; ok { // Expired assert.True( t, - listedAfterExpireAPIKeys[index].Expiration.AsTime().Before(time.Now()), + listedAfterExpireAPIKeys[index].GetExpiration().AsTime().Before(time.Now()), ) } else { // Not expired assert.False( t, - listedAfterExpireAPIKeys[index].Expiration.AsTime().Before(time.Now()), + listedAfterExpireAPIKeys[index].GetExpiration().AsTime().Before(time.Now()), ) } } @@ -744,7 +744,7 @@ func TestNodeTagCommand(t *testing.T) { ) assert.Nil(t, err) - assert.Equal(t, []string{"tag:test"}, node.ForcedTags) + assert.Equal(t, []string{"tag:test"}, node.GetForcedTags()) // try to set a wrong tag and retrieve the error type errOutput struct { @@ -781,8 +781,8 @@ func TestNodeTagCommand(t *testing.T) { assert.Nil(t, err) found := false for _, node := range resultMachines { - if node.ForcedTags != nil { - for _, tag := range node.ForcedTags { + if node.GetForcedTags() != nil { + for _, tag := range node.GetForcedTags() { if tag == "tag:test" { found = true } @@ -885,17 +885,17 @@ func TestNodeCommand(t *testing.T) { assert.Len(t, listAll, 5) - assert.Equal(t, uint64(1), listAll[0].Id) - assert.Equal(t, uint64(2), listAll[1].Id) - assert.Equal(t, uint64(3), listAll[2].Id) - assert.Equal(t, uint64(4), listAll[3].Id) - assert.Equal(t, uint64(5), listAll[4].Id) + assert.Equal(t, uint64(1), listAll[0].GetId()) + assert.Equal(t, uint64(2), listAll[1].GetId()) + assert.Equal(t, uint64(3), listAll[2].GetId()) + assert.Equal(t, uint64(4), listAll[3].GetId()) + assert.Equal(t, uint64(5), listAll[4].GetId()) - assert.Equal(t, "node-1", listAll[0].Name) - assert.Equal(t, "node-2", listAll[1].Name) - assert.Equal(t, "node-3", listAll[2].Name) - assert.Equal(t, "node-4", listAll[3].Name) - assert.Equal(t, "node-5", listAll[4].Name) + assert.Equal(t, "node-1", listAll[0].GetName()) + assert.Equal(t, "node-2", listAll[1].GetName()) + assert.Equal(t, "node-3", listAll[2].GetName()) + assert.Equal(t, "node-4", listAll[3].GetName()) + assert.Equal(t, "node-5", listAll[4].GetName()) otherUserMachineKeys := []string{ "mkey:b5b444774186d4217adcec407563a1223929465ee2c68a4da13af0d0185b4f8e", @@ -963,11 +963,11 @@ func TestNodeCommand(t *testing.T) { // All nodes, nodes + otherUser assert.Len(t, listAllWithotherUser, 7) - assert.Equal(t, uint64(6), listAllWithotherUser[5].Id) - assert.Equal(t, uint64(7), listAllWithotherUser[6].Id) + assert.Equal(t, uint64(6), listAllWithotherUser[5].GetId()) + assert.Equal(t, uint64(7), listAllWithotherUser[6].GetId()) - assert.Equal(t, "otherUser-node-1", listAllWithotherUser[5].Name) - assert.Equal(t, "otherUser-node-2", listAllWithotherUser[6].Name) + assert.Equal(t, "otherUser-node-1", listAllWithotherUser[5].GetName()) + assert.Equal(t, "otherUser-node-2", listAllWithotherUser[6].GetName()) // Test list all nodes after added otherUser var listOnlyotherUserMachineUser []v1.Node @@ -988,18 +988,18 @@ func TestNodeCommand(t *testing.T) { assert.Len(t, listOnlyotherUserMachineUser, 2) - assert.Equal(t, uint64(6), listOnlyotherUserMachineUser[0].Id) - assert.Equal(t, uint64(7), listOnlyotherUserMachineUser[1].Id) + assert.Equal(t, uint64(6), listOnlyotherUserMachineUser[0].GetId()) + assert.Equal(t, uint64(7), listOnlyotherUserMachineUser[1].GetId()) assert.Equal( t, "otherUser-node-1", - listOnlyotherUserMachineUser[0].Name, + listOnlyotherUserMachineUser[0].GetName(), ) assert.Equal( t, "otherUser-node-2", - listOnlyotherUserMachineUser[1].Name, + listOnlyotherUserMachineUser[1].GetName(), ) // Delete a nodes @@ -1123,11 +1123,11 @@ func TestNodeExpireCommand(t *testing.T) { assert.Len(t, listAll, 5) - assert.True(t, listAll[0].Expiry.AsTime().IsZero()) - assert.True(t, listAll[1].Expiry.AsTime().IsZero()) - assert.True(t, listAll[2].Expiry.AsTime().IsZero()) - assert.True(t, listAll[3].Expiry.AsTime().IsZero()) - assert.True(t, listAll[4].Expiry.AsTime().IsZero()) + assert.True(t, listAll[0].GetExpiry().AsTime().IsZero()) + assert.True(t, listAll[1].GetExpiry().AsTime().IsZero()) + assert.True(t, listAll[2].GetExpiry().AsTime().IsZero()) + assert.True(t, listAll[3].GetExpiry().AsTime().IsZero()) + assert.True(t, listAll[4].GetExpiry().AsTime().IsZero()) for idx := 0; idx < 3; idx++ { _, err := headscale.Execute( @@ -1136,7 +1136,7 @@ func TestNodeExpireCommand(t *testing.T) { "nodes", "expire", "--identifier", - fmt.Sprintf("%d", listAll[idx].Id), + fmt.Sprintf("%d", listAll[idx].GetId()), }, ) assert.Nil(t, err) @@ -1158,11 +1158,11 @@ func TestNodeExpireCommand(t *testing.T) { assert.Len(t, listAllAfterExpiry, 5) - assert.True(t, listAllAfterExpiry[0].Expiry.AsTime().Before(time.Now())) - assert.True(t, listAllAfterExpiry[1].Expiry.AsTime().Before(time.Now())) - assert.True(t, listAllAfterExpiry[2].Expiry.AsTime().Before(time.Now())) - assert.True(t, listAllAfterExpiry[3].Expiry.AsTime().IsZero()) - assert.True(t, listAllAfterExpiry[4].Expiry.AsTime().IsZero()) + assert.True(t, listAllAfterExpiry[0].GetExpiry().AsTime().Before(time.Now())) + assert.True(t, listAllAfterExpiry[1].GetExpiry().AsTime().Before(time.Now())) + assert.True(t, listAllAfterExpiry[2].GetExpiry().AsTime().Before(time.Now())) + assert.True(t, listAllAfterExpiry[3].GetExpiry().AsTime().IsZero()) + assert.True(t, listAllAfterExpiry[4].GetExpiry().AsTime().IsZero()) } func TestNodeRenameCommand(t *testing.T) { @@ -1264,7 +1264,7 @@ func TestNodeRenameCommand(t *testing.T) { "nodes", "rename", "--identifier", - fmt.Sprintf("%d", listAll[idx].Id), + fmt.Sprintf("%d", listAll[idx].GetId()), fmt.Sprintf("newnode-%d", idx+1), }, ) @@ -1300,7 +1300,7 @@ func TestNodeRenameCommand(t *testing.T) { "nodes", "rename", "--identifier", - fmt.Sprintf("%d", listAll[4].Id), + fmt.Sprintf("%d", listAll[4].GetId()), "testmaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaachine12345678901234567890", }, ) @@ -1387,11 +1387,11 @@ func TestNodeMoveCommand(t *testing.T) { ) assert.Nil(t, err) - assert.Equal(t, uint64(1), node.Id) - assert.Equal(t, "nomad-node", node.Name) - assert.Equal(t, node.User.Name, "old-user") + assert.Equal(t, uint64(1), node.GetId()) + assert.Equal(t, "nomad-node", node.GetName()) + assert.Equal(t, node.GetUser().GetName(), "old-user") - nodeID := fmt.Sprintf("%d", node.Id) + nodeID := fmt.Sprintf("%d", node.GetId()) err = executeAndUnmarshal( headscale, @@ -1410,7 +1410,7 @@ func TestNodeMoveCommand(t *testing.T) { ) assert.Nil(t, err) - assert.Equal(t, node.User.Name, "new-user") + assert.Equal(t, node.GetUser().GetName(), "new-user") var allNodes []v1.Node err = executeAndUnmarshal( @@ -1428,9 +1428,9 @@ func TestNodeMoveCommand(t *testing.T) { assert.Len(t, allNodes, 1) - assert.Equal(t, allNodes[0].Id, node.Id) - assert.Equal(t, allNodes[0].User, node.User) - assert.Equal(t, allNodes[0].User.Name, "new-user") + assert.Equal(t, allNodes[0].GetId(), node.GetId()) + assert.Equal(t, allNodes[0].GetUser(), node.GetUser()) + assert.Equal(t, allNodes[0].GetUser().GetName(), "new-user") moveToNonExistingNSResult, err := headscale.Execute( []string{ @@ -1452,7 +1452,7 @@ func TestNodeMoveCommand(t *testing.T) { moveToNonExistingNSResult, "user not found", ) - assert.Equal(t, node.User.Name, "new-user") + assert.Equal(t, node.GetUser().GetName(), "new-user") err = executeAndUnmarshal( headscale, @@ -1471,7 +1471,7 @@ func TestNodeMoveCommand(t *testing.T) { ) assert.Nil(t, err) - assert.Equal(t, node.User.Name, "old-user") + assert.Equal(t, node.GetUser().GetName(), "old-user") err = executeAndUnmarshal( headscale, @@ -1490,5 +1490,5 @@ func TestNodeMoveCommand(t *testing.T) { ) assert.Nil(t, err) - assert.Equal(t, node.User.Name, "old-user") + assert.Equal(t, node.GetUser().GetName(), "old-user") } diff --git a/integration/general_test.go b/integration/general_test.go index ca2394aaf3f..afa93e747de 100644 --- a/integration/general_test.go +++ b/integration/general_test.go @@ -530,10 +530,10 @@ func TestExpireNode(t *testing.T) { peerPublicKey := strings.TrimPrefix(peerStatus.PublicKey.String(), "nodekey:") - assert.NotEqual(t, node.NodeKey, peerPublicKey) + assert.NotEqual(t, node.GetNodeKey(), peerPublicKey) } - if client.Hostname() != node.Name { + if client.Hostname() != node.GetName() { // Assert that we have the original count - self - expired node assert.Len(t, status.Peers(), len(MustTestVersions)-2) }