Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: tap-hold-(press|release) with separate action on timeout #314

Closed
jtroo opened this issue Feb 19, 2023 · 3 comments · Fixed by #315
Closed

Feature request: tap-hold-(press|release) with separate action on timeout #314

jtroo opened this issue Feb 19, 2023 · 3 comments · Fixed by #315
Labels
enhancement New feature or request

Comments

@jtroo
Copy link
Owner

jtroo commented Feb 19, 2023

KMonad has a feature where if the equivalent of tap-hold-press or tap-hold-release times out without another key being used, it activates yet another action (different from the tap action or the hold action).

This could be added to kanata, but I personally don't have a use case for it, and I'm unsure how useful this would be. Feel free to add a comment to help gauge interest.

Aside: is there a way to get Github notifications when people add emoji reactions instead of commenting on the thread?

Edit: apparently not yet
community/community#5911
isaacs/github#631

@jtroo jtroo added enhancement New feature or request question Further information is requested PRs welcome jtroo has no plans to work on this at present, but PRs are welcome labels Feb 19, 2023
@jtroo jtroo changed the title Feature request: tap-hold with separate action on timeout Feature request: tap-hold-(press|release) with separate action on timeout Feb 19, 2023
@jtroo jtroo changed the title Feature request: tap-hold-(press|release) with separate action on timeout Feature request: tap-hold-(press|release) with separate action on timeout Feb 19, 2023
@gerhard-h
Copy link
Contributor

Originaly the hold action for letter v was }
but than I needed another convinient layer key so my idea was to
make letter v a layer while held key. But when I don't press any other button before release print }
I tried
(tap-hold 140 140 v (tap-hold-press 200 5000 @} @layerxyz)) but it didn't feel good.
I would feel much better if the @} would be triggert after a time out even without v being released

@jtroo jtroo added selected enhancement New feature or request and removed enhancement New feature or request PRs welcome jtroo has no plans to work on this at present, but PRs are welcome question Further information is requested labels Feb 20, 2023
@jtroo
Copy link
Owner Author

jtroo commented Feb 20, 2023

Implemented in #315, did some basic testing and seems to work. Surprisingly (maybe it shouldn't be?) not that hard to add 🙂

@gerhard-h
Copy link
Contributor

also tested my use case (tap-hold-press-timeout 1 500 v @layerxyz @} ) works and the syntax is simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants