Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling the Ambassadors Page to Work Locally #1495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

idanidan29
Copy link
Contributor

What kind of change does this PR introduce?

Bugfix – This PR fixes a build error that prevented the Ambassadors page from running locally.

Issue Number:

Summary

This PR fixes a local build error by using an Absolute File Path: for the ambassadors.json file. The error occurred due to an incorrect relative path. Node's path module and process.cwd() now ensure the file is correctly located.

Does this PR introduce a breaking change?
no

@idanidan29 idanidan29 requested a review from a team as a code owner March 10, 2025 20:15
Copy link

github-actions bot commented Mar 10, 2025

built with Refined Cloudflare Pages Action

⚑ Cloudflare Pages Deployment

Name Status Preview Last Commit
website βœ… Ready (View Log) Visit Preview ecffc72

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 100.00%. Comparing base (219521e) to head (ecffc72).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1495   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          396       396           
  Branches       106       106           
=========================================
  Hits           396       396           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

πŸ› Bug: Ambassadors Page Not Working Locally
1 participant