Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support python 3.11 ? #61

Closed
nvuillam opened this issue Mar 11, 2023 · 11 comments
Closed

Support python 3.11 ? #61

nvuillam opened this issue Mar 11, 2023 · 11 comments

Comments

@nvuillam
Copy link

It seems that with Python 3.11, sometimes there is the following crash

  File "/usr/local/lib/python3.11/multiprocessing/connection.py", line 378, in _recv
    chunk = read(handle, remaining)
            ^^^^^^^^^^^^^^^^^^^^^^^
TypeError: 'NoneType' object cannot be interpreted as an integer

You can see more details in oxsecurity/megalinter#2425

Would it be possible to provide a fix ?

Many thanks ! :)

cc @llaville

@jruere
Copy link
Owner

jruere commented Mar 11, 2023

I'll look into it.

In the reference issue, the problem seems not to be in this package, we are just receiving from a queue.

@nvuillam Could you provide a small script to reproduce?

@nvuillam
Copy link
Author

The queue seems to be managed by multiprocessing-logging , and when we use it without parallizing the process there is no issue

I am unfortunately unable to reproduce the issue, but @llaville maybe you can help ?

@llaville
Copy link

@jruere, /cc @nvuillam I'll be short in time, and did not provide any more help this afternoon until tomorrow morning !

But here is a quick steps to follows :

  1. Clone my repository git clone https://github.com/llaville/php-compatinfo-db.git (master branch)
  2. Download Megalinter v6.20.1 docker image (PHP flavor image) => docker pull oxsecurity/megalinter-php:v6
  3. Run following command sudo rm -rf megalinter-reports/ && time docker run --rm -v /var/run/docker.sock:/var/run/docker.sock:rw -v $(pwd):/tmp/lint:rw oxsecurity/megalinter-php:v6

As I've disable PARALLEL mode in my config file => https://github.com/llaville/php-compatinfo-db/blob/master/.mega-linter.yml#L38
You must enable it to see results !

@llaville
Copy link

My platform is :

  • Docker version 23.0.1, build a5ee5b1
  • Ubuntu 22.04.2 LTS (GNU/Linux 5.15.90.1-microsoft-standard-WSL2 x86_64)

@jruere
Copy link
Owner

jruere commented Mar 11, 2023

Thanks for the help!

@llaville
Copy link

@jruere is there some news ?

@jruere
Copy link
Owner

jruere commented Apr 16, 2023

I completely forgot! I'm not available next week I'll take a note to work on this the other week.

Sorry for the delay.

@llaville
Copy link

I supposed you've still not work on this purpose ?

I'm sad, because performance of MegaLinter when PARALLEL mode is disabled is poor, especially when we we lot of files.
E.g:

MegaLinter_Parallel_On

@zerocewl
Copy link

Any updates?

@llaville
Copy link

llaville commented Feb 8, 2024

No news since a very long time.

BTW, as I've migrated from MegaLinter v6 to v7 today, I've no more PARALLEL issue.

Certainly because MegaLinter v6 use Python 3.11, while MegaLinter v 7 use Python 3.12

@nvuillam You should close this report !

@nvuillam
Copy link
Author

nvuillam commented Feb 8, 2024

@llaville i think the fix has been released :)

@nvuillam nvuillam closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants