Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low Contrast Text on Webpage #1061

Closed
ghost opened this issue Oct 25, 2020 · 7 comments · Fixed by #1105
Closed

Low Contrast Text on Webpage #1061

ghost opened this issue Oct 25, 2020 · 7 comments · Fixed by #1105
Labels
documentation Improvements or additions to documentation enhancement New feature or request 📌 This can't go stale

Comments

@ghost
Copy link

ghost commented Oct 25, 2020

Feature Request

Use Case/Motivation

https://contrastrebellion.com/

Example Usage

color: #000 in div.flex

Other information

@ghost ghost added 🆕 New! enhancement New feature or request labels Oct 25, 2020
@wren wren added the documentation Improvements or additions to documentation label Oct 26, 2020
@wren
Copy link
Member

wren commented Oct 26, 2020

Hi, @klorophatu! Thanks for reporting this. Accessibility is important.

Could you please give some more specific details about which parts of the website don't have enough contrast? Some screenshots, if you have them, would also be very useful.

@wren
Copy link
Member

wren commented Oct 26, 2020

Scanning jrnl.sh with a11y shows this:

Screen Shot 2020-10-26 at 11 00 17 AM

For the failed results:

  1. At a quick glance, I don't see where there's any white text on light grey background. So, I'm guessing this is some quirk in the scan. Maybe some bg property we're not setting correctly?
  2. This is the grey text on grey background, which is absolutely not enough contrast, and I'm guessing what the OP was about. Should be an easy fix, though.

@wren
Copy link
Member

wren commented Oct 26, 2020

For the other pages (this one is from overview):

Screen Shot 2020-10-26 at 11 03 35 AM

It looks like our blue link color is close, but just shy of the contrast requirements. We should pick out a slightly more contrasty blue.

@wren
Copy link
Member

wren commented Oct 26, 2020

Ouch, I won't paste the results here (because they don't fit on my screen for a screenshot), but our syntax highlighting has a lot of problems (scan https://jrnl.readthedocs.io/en/latest/formats/ with the tool linked above).

@wren
Copy link
Member

wren commented Oct 26, 2020

Also, since I'm just spamming this thread apparently, are there are good ways for us to automate these tests? Maybe it's not worth automating since we don't change our colors often, but if it's simple, it could streamline site updates in the future.

@wren wren added the 📌 This can't go stale label Oct 26, 2020
@wren wren removed the 🆕 New! label Oct 31, 2020
@wren
Copy link
Member

wren commented Nov 14, 2020

cc #1005

@wren
Copy link
Member

wren commented Dec 12, 2020

You can view this now here: https://jrnl.sh/en/latest/

With the next release, it'll be merged into the stable channel, and will be the default for everyone.

Thanks, again for pointing this out, @klorophatu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request 📌 This can't go stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant