New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate implementation of git-archive-all #656

Open

jorisv opened this issue Jan 22, 2024 · 1 comment

Labels

Contributor

jorisv commented Jan 22, 2024

git-archive-all.sh and git-archive-all.py are both used by dist.cmake to create tar.gz archive of the sources with submodules.

The bash one is used on Windows and Linux, the Python one is used on MacOS.

Is there any reason to maintains both scripts ? If not, we can maybe use the Python script on all platform.

jorisv added the Enhancement label

Collaborator

nim65s commented Jan 22, 2024

I'm using https://github.com/Kentzo/git-archive-all both on linux and macos without issues, so yes, I think we can keep only the python version (and maybe consider updating it from upstream)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment