-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak github actions setup so that docker layers are cached better #8
Comments
the situation is even worse now that i changed docker-compose-test to build its own rask_api image. the gha docker image layer caching story is evolving and not super great atm. we need to cache built deps/layers across these three situations:
right now i don't think there's working caching for any of those steps :) |
thought about this a bit more, here's a sketch of a possible direction:
so in my head the main github action workflow would end up looking something like this:
yeesh. that sounded simpler in my head. |
TODO: see what other projects do!!! |
right now docker builds take ~5 minutes, and no layers are cached except the layers from the last stage, which don't save us any time. cargo-chef and buildx's
gha
caching are supposed to do nice caching things, but they don't seem to be doing that in this setup right now.one possible theory: maybe cargo-chef is violating some assumptions of buildx's caching? maybe buildx only caches the final layer intentionally for some reason? no clue.
The text was updated successfully, but these errors were encountered: