From b08043dd19ee75a5c8421f504f9c7a73d833e81f Mon Sep 17 00:00:00 2001 From: rajeshmn47 Date: Wed, 15 Feb 2023 22:23:37 +0530 Subject: [PATCH 1/3] fix: Setting a view as false in views prop should turn it off #2316 --- src/Calendar.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/Calendar.js b/src/Calendar.js index 8a2cb6a282..b8761f155f 100644 --- a/src/Calendar.js +++ b/src/Calendar.js @@ -26,6 +26,11 @@ import mapValues from 'lodash/mapValues' import { wrapAccessor } from './utils/accessors' function viewNames(_views) { + for (let i = 0; i < Object.keys(_views).length; i++) { + if (_views[Object.keys(_views)[i]] == false) { + delete _views[Object.keys(_views)[i]] + } + } return !Array.isArray(_views) ? Object.keys(_views) : _views } From 3a3c2eefe6d34942873a66da3527882d7174c4d8 Mon Sep 17 00:00:00 2001 From: rajeshmn47 Date: Wed, 15 Feb 2023 22:25:36 +0530 Subject: [PATCH 2/3] fix: Setting a view as false in views prop should turn it off #2316 --- src/Calendar.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Calendar.js b/src/Calendar.js index b8761f155f..f191c86d0d 100644 --- a/src/Calendar.js +++ b/src/Calendar.js @@ -52,7 +52,7 @@ class Calendar extends React.Component { * const localizer = globalizeLocalizer(globalize) * ``` * moment - * ```js + * ``js * import {momentLocalizer} from 'react-big-calendar' * import moment from 'moment' * // and, for optional time zone support From 314fb10ecf91bc88fe7150c346d95939d8e36c41 Mon Sep 17 00:00:00 2001 From: rajeshmn47 Date: Fri, 17 Feb 2023 15:23:03 +0530 Subject: [PATCH 3/3] fix: Setting a view as false in views prop should turn it off #2316 --- src/Calendar.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/Calendar.js b/src/Calendar.js index f191c86d0d..cf70d23912 100644 --- a/src/Calendar.js +++ b/src/Calendar.js @@ -26,12 +26,16 @@ import mapValues from 'lodash/mapValues' import { wrapAccessor } from './utils/accessors' function viewNames(_views) { - for (let i = 0; i < Object.keys(_views).length; i++) { - if (_views[Object.keys(_views)[i]] == false) { - delete _views[Object.keys(_views)[i]] + if (Array.isArray(_views)) { + return _views + } + const views = [] + for (const [key, value] of Object.entries(_views)) { + if (value) { + views.push(key) } } - return !Array.isArray(_views) ? Object.keys(_views) : _views + return views } function isValidView(view, { views: _views }) {