Make http.request correctly parse {host: "hostname:port"} #25752

nfriedly · 2015-07-22T17:45:52Z

Fixes #25751 so that http.request() doesn't attempt an invalid dns lookup of hostname:port when it should only be looking up hostname.

jasnell · 2015-08-06T17:29:38Z

Going to close this here. If it lands, io.js or the converged branch will be the right place. This shouldn't land in v0.12 or v0.10

nfriedly added 2 commits July 22, 2015 13:32

make http.request parse port out of host option. Fixes nodejs#25751

0214cac

style tweaks to make jshint happy

0343def

This was referenced Jul 29, 2015

Make http.request correctly parse {host: "hostname:port"} nodejs/node#2271

Closed

Make http.request correctly parse {host: "hostname:port"} nodejs/node-convergence-archive#72

Closed

jasnell closed this Aug 6, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make http.request correctly parse {host: "hostname:port"} #25752

Make http.request correctly parse {host: "hostname:port"} #25752

nfriedly commented Jul 22, 2015

jasnell commented Aug 6, 2015

Make http.request correctly parse {host: "hostname:port"} #25752

Make http.request correctly parse {host: "hostname:port"} #25752

Conversation

nfriedly commented Jul 22, 2015

jasnell commented Aug 6, 2015